Issue 2490041: code review 2490041: 5l, 6l, 8l: indent, outdent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2490041: code review 2490041: 5l, 6l, 8l: indent, outdent (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

5l, 6l, 8l: indent, outdent This is entirely adding and removing tabs. It looks weird but will make the diffs for the next change easier to read.

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1676 lines, -1676 lines)			Patch
M	src/cmd/5l/asm.c	View	2 chunks	+37 lines, -37 lines	0 comments	Download
M	src/cmd/5l/noop.c	View	2 chunks	+701 lines, -701 lines	0 comments	Download
M	src/cmd/5l/pass.c	View	1 chunk	+65 lines, -65 lines	0 comments	Download
M	src/cmd/5l/softfloat.c	View	1 chunk	+39 lines, -39 lines	0 comments	Download
M	src/cmd/5l/span.c	View	3 chunks	+124 lines, -124 lines	0 comments	Download
M	src/cmd/6l/asm.c	View	1 chunk	+30 lines, -30 lines	0 comments	Download
M	src/cmd/6l/pass.c	View	2 chunks	+223 lines, -223 lines	0 comments	Download
M	src/cmd/6l/span.c	View	3 chunks	+44 lines, -44 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1 chunk	+48 lines, -48 lines	0 comments	Download
M	src/cmd/8l/pass.c	View	2 chunks	+270 lines, -270 lines	0 comments	Download
M	src/cmd/8l/span.c	View	2 chunks	+38 lines, -38 lines	0 comments	Download
M	src/cmd/ld/lib.c	View	1 chunk	+57 lines, -57 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-10-13 19:19:51 UTC) #1

rsc

*** Submitted as de4ee3de0bbf *** 5l, 6l, 8l: indent, outdent This is entirely adding and ...

14 years, 9 months ago (2010-10-13 19:19:56 UTC) #2

lgtm