Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 2481042: code review 2481042: 8l: function at a time code layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by rsc
Modified:
14 years, 8 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

8l: function at a time code layout

Patch Set 1 #

Patch Set 2 : code review 2481042: 8l: function at a time code layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -253 lines) Patch
M src/cmd/6l/span.c View 2 chunks +1 line, -5 lines 0 comments Download
M src/cmd/8l/asm.c View 3 chunks +4 lines, -51 lines 0 comments Download
M src/cmd/8l/l.h View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8l/span.c View 18 chunks +343 lines, -196 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-10-16 00:19:55 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=749a9400cd2a *** 8l: function at a time code layout R=ken2 CC=golang-dev http://codereview.appspot.com/2481042
14 years, 8 months ago (2010-10-16 00:20:02 UTC) #2
ken3
lgtm does this work? there are load options (data right after text) where you need ...
14 years, 8 months ago (2010-10-16 00:52:32 UTC) #3
rsc
14 years, 8 months ago (2010-10-16 03:43:09 UTC) #4
> lgtm
>
> does this work?
> there are load options (data right after text)
> where you need the size of the last func
> in order to lay out the first.

yes, i believe it works.
when the func gets laid out none of the data addresses
are filled in yet, but we know they're all 32-bit numbers
so it doesn't affect size.  once all the addresses are
known, after span() and dodata(), reloc() goes and fills them in.

russ
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b