Issue 2479043: code review 2479043: 5l: data-relocatable code layout

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2479043: code review 2479043: 5l: data-relocatable code layout (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by rsc

Modified:
14 years, 8 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

5l: data-relocatable code layout

Patch Set 1 #

Patch Set 2 : code review 2479043: 5l: data-relocatable code layout #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -39 lines)			Patch
M	src/cmd/5l/asm.c	View		5 chunks	+21 lines, -25 lines	0 comments	Download
M	src/cmd/5l/l.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5l/obj.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/5l/span.c	View	1	9 chunks	+40 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-18 15:09:57 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=e0680c0cce5f *** 5l: data-relocatable code layout R=ken2 CC=golang-dev http://codereview.appspot.com/2479043

14 years, 8 months ago (2010-10-18 15:10:08 UTC) #2

lgtm

Expand All Messages | Collapse All Messages