Issue 2478042: issue 9807 part 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2478042: issue 9807 part 1

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by barry

Modified:
14 years, 6 months ago

Reviewers:
Antoine Pitrou

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Patch Set 2 : fixed python-config.in #

Total comments: 6

Patch Set 3 : resolve ap's comments #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -45 lines)			Patch
M	Doc/library/sys.rst	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Lib/test/test_sys.py	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Makefile.pre.in	View	1 2	4 chunks	+8 lines, -1 line	0 comments	Download
M	Misc/python-config.in	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	Python/sysmodule.c	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	configure	View	1 2	12 chunks	+39 lines, -21 lines	0 comments	Download
M	configure.in	View	1 2	9 chunks	+32 lines, -20 lines	0 comments	Download
M	pyconfig.h.in	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Antoine Pitrou

http://codereview.appspot.com/2478042/diff/2001/configure.in File configure.in (right): http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3646 configure.in:3646: # shared library name on some platforms. Why only ...

14 years, 6 months ago (2010-10-14 23:00:57 UTC) #1

barry

14 years, 6 months ago (2010-10-15 16:25:42 UTC) #2

http://codereview.appspot.com/2478042/diff/2001/configure.in
File configure.in (right):

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3646
configure.in:3646: # shared library name on some platforms.
On 2010/10/14 23:00:57, Antoine Pitrou wrote:
> Why only some platforms? Where does the list come from?

From earlier sections, IIRC.  I don't think we have an official list of shared
library supported platforms, so we'll just have to modify this list as platform
champions come forward.

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3649
configure.in:3649: SunOS*)
On 2010/10/14 23:00:57, Antoine Pitrou wrote:
> Why a separate case for SunOS? I don't see any difference.

I grabbed this from an earlier section with enabled_shared, but you're right,
after modification, there's no difference so I'll roll this into one clause.

http://codereview.appspot.com/2478042/diff/2001/configure.in#newcode3653
configure.in:3653: INSTSONAME="$LDLIBRARY".$SOVERSION.${ABIFLAGS}
On 2010/10/14 23:00:57, Antoine Pitrou wrote:
> Please put the ABIFLAGS before the ".so.3.2".

Right, we did agree to that.  It's not a simple change though because $LDLIBRARY
needs to use a different variable than $VERSION.  It's actually a PITA ;) and
will necessitate changes on OSes I don't have access to, so informing python-dev
will be required.  I'll see what I can do though.

Expand All Messages | Collapse All Messages