Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16355)

Issue 246041: Show how to properly support the Gonville font. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by hanwenn
Modified:
13 years, 2 months ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Show how to properly support the Gonville font. Example in input/gonville.ly; it is not part of the regtest, since we currently do not ship Gonville. This still does not work for alphabet glyphs, since those are still hardcoded to feta-alphabet, and are loaded through Pango. Rename aybabtu font to emmentaler-brace. Pass a list of design sizes into add-music-fonts function. This prepares for music fonts that come in just one design size.

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2nd try at uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -116 lines) Patch
M ROADMAP View 1 chunk +1 line, -1 line 0 comments Download
A input/gonville.ly View 1 chunk +62 lines, -0 lines 0 comments Download
D input/regression/gonville.ly View 1 chunk +0 lines, -59 lines 0 comments Download
M lily/all-font-metrics-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/font-metric-scheme.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M mf/GNUmakefile View 4 chunks +17 lines, -17 lines 0 comments Download
A + mf/emmentaler-brace.pe.in View 2 chunks +6 lines, -6 lines 0 comments Download
scm/define-grob-properties.scm View 1 chunk +2 lines, -2 lines 0 comments Download
scm/font.scm View 3 chunks +20 lines, -20 lines 0 comments Download
scm/framework-ps.scm View 1 chunk +1 line, -2 lines 0 comments Download
scm/lily-library.scm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4
hanwenn
Hi, I didnt see the mail from the review come through, so: please review.
14 years, 1 month ago (2010-03-05 05:38:49 UTC) #1
Carl
I've reviewed the stuff I could, and it looks good to me. However, none of ...
14 years, 1 month ago (2010-03-06 15:58:37 UTC) #2
hanwenn
For some reasonn, the side-by-side diffs are broken, but the inline ones seem to work. ...
14 years, 1 month ago (2010-03-06 17:01:39 UTC) #3
Carl
14 years, 1 month ago (2010-03-06 17:06:03 UTC) #4
LGTM.

Thanks,

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b