Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 244041: code review 244041: arm: cleanup build warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by dpx
Modified:
15 years, 3 months ago
Reviewers:
CC:
kaib, rsc, golang-dev
Visibility:
Public.

Description

arm: cleanup build warnings trivial stuff lex.c: these prototypes are in a.h asm.c: unused variables arm-pass.txt deal w/ sieve.go rename and addition of sieve2.go

Patch Set 1 #

Patch Set 2 : code review 244041: arm: cleanup build warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/cmd/5a/lex.c View 1 chunk +0 lines, -3 lines 0 comments Download
M src/cmd/5l/asm.c View 1 chunk +2 lines, -2 lines 0 comments Download
M test/arm-pass.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
dpx
Hello kaib (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 3 months ago (2010-03-05 03:22:29 UTC) #1
kaib
lgtm
15 years, 3 months ago (2010-03-05 07:51:41 UTC) #2
kaib
@dean: i'm currently traveling and can't easily access a machine that lets me submit this ...
15 years, 3 months ago (2010-03-05 08:21:24 UTC) #3
dpx
ping. On Fri, Mar 5, 2010 at 1:21 AM, <kaib@golang.org> wrote: > @dean: i'm currently ...
15 years, 3 months ago (2010-03-09 01:23:02 UTC) #4
rsc1
LGTM
15 years, 3 months ago (2010-03-09 02:12:16 UTC) #5
rsc
15 years, 3 months ago (2010-03-09 02:13:23 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=a3b6b511bbcc ***

arm: cleanup build warnings

trivial stuff
lex.c: these prototypes are in a.h
asm.c: unused variables
arm-pass.txt deal w/ sieve.go rename and addition of sieve2.go

R=kaib, rsc
CC=golang-dev
http://codereview.appspot.com/244041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b