LGTM On Oct 11, 2010 10:11 PM, <rsc@golang.org> wrote: > Reviewers: lvd, > > Message: ...
14 years, 9 months ago
(2010-10-11 20:14:04 UTC)
#2
LGTM
On Oct 11, 2010 10:11 PM, <rsc@golang.org> wrote:
> Reviewers: lvd,
>
> Message:
> Hello lvd (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> ld: be less picky about bad line number info
>
> Please review this at http://codereview.appspot.com/2439041/
>
> Affected files:
> M src/cmd/ld/dwarf.c
>
>
> Index: src/cmd/ld/dwarf.c
> ===================================================================
> --- a/src/cmd/ld/dwarf.c
> +++ b/src/cmd/ld/dwarf.c
> @@ -763,7 +763,7 @@
> continue;
> }
> if (lh->file < 1) { // 0 is the past-EOF entry.
> - diag("instruction with linenumber past EOF in %s: %P", unitname, q);
> + //diag("instruction with linenumber past EOF in %s: %P", unitname, q);
> continue;
> }
>
>
>
*** Submitted as 86b670199bb5 *** ld: be less picky about bad line number info Fixes ...
14 years, 9 months ago
(2010-10-11 20:21:07 UTC)
#3
*** Submitted as 86b670199bb5 ***
ld: be less picky about bad line number info
Fixes issue 1175.
R=lvd
CC=golang-dev
http://codereview.appspot.com/2439041
Issue 2439041: code review 2439041: ld: be less picky about bad line number info
(Closed)
Created 14 years, 9 months ago by rsc
Modified 14 years, 9 months ago
Reviewers:
Base URL:
Comments: 0