Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1379)

Issue 2401042: convert: properly escape some single-backslashes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Graham Percival (old account)
Modified:
13 years, 5 months ago
Reviewers:
dak, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

convert: properly escape some single-backslashes.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update convert-ly description strings. #

Patch Set 3 : oops, forgot to deal with \* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M python/convertrules.py View 1 2 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7
Graham Percival (old account)
I noticed a few weird error messages while testing convert-ly on the docs.
13 years, 5 months ago (2010-10-11 17:18:19 UTC) #1
dak
http://codereview.appspot.com/2401042/diff/1/python/convertrules.py File python/convertrules.py (right): http://codereview.appspot.com/2401042/diff/1/python/convertrules.py#newcode2992 python/convertrules.py:2992: _ ("\\RemoveEmpty*StaffContext -> \*Staff \\RemoveEmptyStaves")) Any particular reason that ...
13 years, 5 months ago (2010-10-11 18:18:37 UTC) #2
Graham Percival (old account)
On 2010/10/11 18:18:37, dak wrote: > python/convertrules.py:2992: _ ("\\RemoveEmpty*StaffContext -> \*Staff > \\RemoveEmptyStaves")) > Any ...
13 years, 5 months ago (2010-10-11 20:55:05 UTC) #3
dak
percival.music.ca@gmail.com writes: > On 2010/10/11 18:18:37, dak wrote: >> python/convertrules.py:2992: _ ("\\RemoveEmpty*StaffContext -> \*Staff >> ...
13 years, 5 months ago (2010-10-12 06:23:56 UTC) #4
Graham Percival (old account)
On 2010/10/12 06:23:56, dak wrote: > mailto:percival.music.ca@gmail.com writes: > > Is that not a documentation ...
13 years, 5 months ago (2010-10-13 20:28:16 UTC) #5
Carl
LGTM. Carl
13 years, 5 months ago (2010-10-20 14:06:45 UTC) #6
Graham Percival (old account)
13 years, 5 months ago (2010-10-21 08:08:54 UTC) #7
On 2010/10/20 14:06:45, Carl wrote:
> LGTM.
> 
> Carl

thanks pushed.  Closing this issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b