Issue 2390042: code review 2390042: emit correct offset for __nl_symbol_ptr in mach-o linke...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2390042: code review 2390042: emit correct offset for __nl_symbol_ptr in mach-o linke... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by mcgoo

Modified:
14 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

emit correct offset for __nl_symbol_ptr in mach-o linker. Fixes malformed object message from nm etc. Fixes issue 1180.

Patch Set 1 #

Patch Set 2 : code review 2390042: emit correct offset for __nl_symbol_ptr in mach-o linke... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/cmd/ld/macho.c	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mcgoo

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-10-08 18:52:10 UTC) #1

rsc

14 years, 7 months ago (2010-10-11 18:45:04 UTC) #3

*** Submitted as 129c10732795 ***

6l: correct offset for __nl_symbol_ptr in Mach-O.

Fixes malformed object message from nm etc.
Fixes issue 1180.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/2390042

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages