Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3250)

Issue 238043: break statements don't work in spans mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by ckulla
Modified:
14 years ago
Reviewers:
dev-osl, larrygritz, osl-dev
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When using the new SHADE_LOOP_BEGIN/END macros in runspans mode, we actually use two nested loops which means a simple "break" statement will not work as expected. This patch adds a new macro: SHADE_LOOP_EXIT which does the right thing, and fixes all the ops that were using break statements incorrectly.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
src/liboslexec/exec.cpp View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/opcontrol.cpp View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/opmessage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
src/liboslexec/opstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/optexture.cpp View 2 chunks +1 line, -3 lines 1 comment Download
src/liboslexec/opvector.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
src/liboslexec/oslops.h View 3 chunks +7 lines, -0 lines 1 comment Download

Messages

Total messages: 4
ckulla
14 years ago (2010-03-06 00:50:32 UTC) #1
larrygritz
LGTM, other than my comment about the Result derivs in optexture.cpp. Thanks for fixing this. ...
14 years ago (2010-03-06 00:56:59 UTC) #2
ckulla
> http://codereview.appspot.com/238043/diff/1/2#oldcode291 > src/liboslexec/optexture.cpp:291: if (Result.has_derivs()) > Why is this no longer needed? Because the ...
14 years ago (2010-03-06 00:57:47 UTC) #3
lg_imageworks.com
14 years ago (2010-03-06 01:11:54 UTC) #4
Right.  Duh.  OK, all fine then.


On Mar 5, 2010, at 4:57 PM, <ckulla@gmail.com> <ckulla@gmail.com> wrote:

>> http://codereview.appspot.com/238043/diff/1/2#oldcode291
>> src/liboslexec/optexture.cpp:291: if (Result.has_derivs())
>> Why is this no longer needed?
> 
> Because the result is an integer.
> 
> 
> 
> http://codereview.appspot.com/238043/show
> 

--
Larry Gritz
lg@imageworks.com




Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b