Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 2380041: Style: disable removal of "gratuitous" blocks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Graham Percival (old account)
Modified:
13 years, 6 months ago
Reviewers:
c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Style: disable removal of "gratuitous" blocks. This rule removed any {} which were around a single statment, but this removal broke any .h file with short inline function definitions (such as a "getFoo() { return foo; }"). The templates in flower/include/std-vector.hh were hit particularly hard by this rule. Style: clarify "do nothing" macro with {}; This stops fixcc.py from adding a space in ASSERT_LIVE_IS_ALLOWED()

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M lily/include/smobs.hh View 1 chunk +1 line, -1 line 0 comments Download
M scripts/auxiliar/fixcc.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Graham Percival (old account)
Here's two patches (confusingly merged together by git cl :( that complete the "make fixcc.py ...
13 years, 7 months ago (2010-10-06 16:55:53 UTC) #1
c_sorensen
13 years, 7 months ago (2010-10-06 17:46:23 UTC) #2


On 10/6/10 10:55 AM, "percival.music.ca@gmail.com"
<percival.music.ca@gmail.com> wrote:

> Reviewers: ,
> 
> Message:
> Here's two patches (confusingly merged together by git cl :(

To avoid that problem in the future, you'll want to have two separate
branches (a pain, I know, but it's doable.


As for the patch, LGTM.

Thanks,

Carl

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b