bugs.python.org issue9807

[Antoine Pitrou, 2010-10-01 22:43:19]

http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py
File Lib/sysconfig.py (right):

http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py#newcode24
Lib/sysconfig.py:24: 'stdlib':
'{base}/lib/python{py_version_short}{soabi_qualifiers}',
Isn't appending this creating lots of ugly paths?

http://codereview.appspot.com/2340041/diff/1/Makefile.pre.in
File Makefile.pre.in (right):

http://codereview.appspot.com/2340041/diff/1/Makefile.pre.in#newcode110
Makefile.pre.in:110:
INCLUDEPY=	$(INCLUDEDIR)/python$(VERSION)$(SOABI_QUALIFIERS)
Why does this have to depend on SOABI_QUALIFIERS?

http://codereview.appspot.com/2340041/diff/1/configure
File configure (right):

http://codereview.appspot.com/2340041/diff/1/configure#newcode4
configure:4: # Generated by GNU Autoconf 2.67 for python 3.2.
Not sure it's ok to use a different autoconf version.

[Martin v. Löwis, 2010-10-01 22:51:24]

http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in
File Misc/python-config.in (right):

http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in#newcode61
Misc/python-config.in:61: print(sys.soabi_qualifiers)
For consistency, I think the sys variable and the command line option should be
spelled similarly (unless there is already precedence for an abiflags -config
argument)

[barry, 2010-10-11 21:31:06]

http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py
File Lib/sysconfig.py (right):

http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py#newcode24
Lib/sysconfig.py:24: 'stdlib':
'{base}/lib/python{py_version_short}{soabi_qualifiers}',
On 2010/10/01 22:43:19, Antoine Pitrou wrote:
> Isn't appending this creating lots of ugly paths?

Depends on what you mean by "ugly" :).  The paths are longer by a couple of
characters, but they map to PEP 3147 flag names, so I think it is easy to
document.  Besides, who actually looks for these?

http://codereview.appspot.com/2340041/diff/1/Makefile.pre.in
File Makefile.pre.in (right):

http://codereview.appspot.com/2340041/diff/1/Makefile.pre.in#newcode110
Makefile.pre.in:110:
INCLUDEPY=	$(INCLUDEDIR)/python$(VERSION)$(SOABI_QUALIFIERS)
On 2010/10/01 22:43:19, Antoine Pitrou wrote:
> Why does this have to depend on SOABI_QUALIFIERS?

It needs to be discriminated on the build-flags, because things like pyconfig.h
get stored there, and that has configure flag specific information in them.

http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in
File Misc/python-config.in (right):

http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in#newcode61
Misc/python-config.in:61: print(sys.soabi_qualifiers)
On 2010/10/01 22:51:24, Martin v. Löwis wrote:
> For consistency, I think the sys variable and the command line option should
be
> spelled similarly (unless there is already precedence for an abiflags -config
> argument)

You make a good point.  For a while, I've been thinking about renaming
SOABI_QUALIFIERS too.  I think they can all be renamed 'abiflags' (with proper
capitalization, for consistency.  What do you think?

http://codereview.appspot.com/2340041/diff/1/configure
File configure (right):

http://codereview.appspot.com/2340041/diff/1/configure#newcode4
configure:4: # Generated by GNU Autoconf 2.67 for python 3.2.
On 2010/10/01 22:43:19, Antoine Pitrou wrote:
> Not sure it's ok to use a different autoconf version.

I'll double check (this is anyway the version that's on the Ubuntu 10.10 I'm
using).  It probably doesn't make a difference, but I'll see if I can find any
incompatibilities that might bite e.g. the buildbots.

[barry, 2010-10-14 20:44:59]

http://codereview.appspot.com/2340041/diff/1/configure
File configure (right):

http://codereview.appspot.com/2340041/diff/1/configure#newcode4
configure:4: # Generated by GNU Autoconf 2.67 for python 3.2.
On 2010/10/11 21:31:06, barry wrote:
> On 2010/10/01 22:43:19, Antoine Pitrou wrote:
> > Not sure it's ok to use a different autoconf version.
> 
> I'll double check (this is anyway the version that's on the Ubuntu 10.10 I'm
> using).  It probably doesn't make a difference, but I'll see if I can find any
> incompatibilities that might bite e.g. the buildbots.

This actually just came up on python-dev in another context.  It's fine.