Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1219)

Issue 2340041: bugs.python.org issue9807

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by barry
Modified:
13 years, 5 months ago
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -270 lines) Patch
M Lib/distutils/sysconfig.py View 3 chunks +18 lines, -1 line 0 comments Download
M Lib/sysconfig.py View 3 chunks +8 lines, -4 lines 2 comments Download
M Makefile.pre.in View 6 chunks +15 lines, -6 lines 2 comments Download
M Misc/python-config.in View 2 chunks +4 lines, -1 line 2 comments Download
M Python/sysmodule.c View 1 chunk +4 lines, -0 lines 0 comments Download
M configure View 122 chunks +282 lines, -256 lines 3 comments Download
M configure.in View 2 chunks +3 lines, -0 lines 0 comments Download
M pyconfig.h.in View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Antoine Pitrou
http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py File Lib/sysconfig.py (right): http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py#newcode24 Lib/sysconfig.py:24: 'stdlib': '{base}/lib/python{py_version_short}{soabi_qualifiers}', Isn't appending this creating lots of ugly ...
13 years, 6 months ago (2010-10-01 22:43:19 UTC) #1
Martin v. Löwis
http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in File Misc/python-config.in (right): http://codereview.appspot.com/2340041/diff/1/Misc/python-config.in#newcode61 Misc/python-config.in:61: print(sys.soabi_qualifiers) For consistency, I think the sys variable and ...
13 years, 6 months ago (2010-10-01 22:51:24 UTC) #2
barry
http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py File Lib/sysconfig.py (right): http://codereview.appspot.com/2340041/diff/1/Lib/sysconfig.py#newcode24 Lib/sysconfig.py:24: 'stdlib': '{base}/lib/python{py_version_short}{soabi_qualifiers}', On 2010/10/01 22:43:19, Antoine Pitrou wrote: > ...
13 years, 5 months ago (2010-10-11 21:31:06 UTC) #3
barry
13 years, 5 months ago (2010-10-14 20:44:59 UTC) #4
http://codereview.appspot.com/2340041/diff/1/configure
File configure (right):

http://codereview.appspot.com/2340041/diff/1/configure#newcode4
configure:4: # Generated by GNU Autoconf 2.67 for python 3.2.
On 2010/10/11 21:31:06, barry wrote:
> On 2010/10/01 22:43:19, Antoine Pitrou wrote:
> > Not sure it's ok to use a different autoconf version.
> 
> I'll double check (this is anyway the version that's on the Ubuntu 10.10 I'm
> using).  It probably doesn't make a difference, but I'll see if I can find any
> incompatibilities that might bite e.g. the buildbots.

This actually just came up on python-dev in another context.  It's fine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b