Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(427)

Issue 2335043: code review 2335043: 6l: cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by rsc
Modified:
15 years ago
Reviewers:
CC:
ken2, r, ken3, golang-dev
Visibility:
Public.

Description

5l, 6l, 8l: first pass cleanup * Maintain Sym* list for text with individual prog lists instead of using one huge list and overloading p->pcond. * Comment what each file is for. * Move some output code from span.c to asm.c. * Move profiling into prof.c, symbol table into symtab.c. * Move mkfwd to ld/lib.c. * Throw away dhog dynamic loading code. * Throw away Alef become. * Fix printing of WORD instructions in 5l -a. Goal here is to be able to handle each piece of text or data as a separate piece, both to make it easier to load the occasional .o file and also to make it possible to split the work across multiple threads.

Patch Set 1 #

Patch Set 2 : code review 2335043: ld fiddling #

Patch Set 3 : code review 2335043: ld fiddling #

Patch Set 4 : code review 2335043: 6l: cleanup #

Patch Set 5 : code review 2335043: 6l: cleanup #

Patch Set 6 : code review 2335043: 5l, 6l, 8l: first pass cleanup #

Patch Set 7 : code review 2335043: 5l, 6l, 8l: first pass cleanup #

Patch Set 8 : code review 2335043: 5l, 6l, 8l: first pass cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2087 lines, -3736 lines) Patch
M src/cmd/5c/peep.c View 1 chunk +0 lines, -2 lines 0 comments Download
M src/cmd/5g/list.c View 1 chunk +0 lines, -2 lines 0 comments Download
M src/cmd/5l/5.out.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/5l/Makefile View 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/5l/asm.c View 6 23 chunks +33 lines, -201 lines 0 comments Download
M src/cmd/5l/l.h View 1 2 16 chunks +15 lines, -43 lines 0 comments Download
M src/cmd/5l/list.c View 6 3 chunks +15 lines, -10 lines 0 comments Download
M src/cmd/5l/noop.c View 23 chunks +48 lines, -213 lines 0 comments Download
M src/cmd/5l/obj.c View 15 chunks +40 lines, -323 lines 0 comments Download
M src/cmd/5l/pass.c View 6 25 chunks +52 lines, -352 lines 0 comments Download
A src/cmd/5l/prof.c View 1 chunk +214 lines, -0 lines 0 comments Download
M src/cmd/5l/softfloat.c View 6 3 chunks +7 lines, -11 lines 0 comments Download
M src/cmd/5l/span.c View 17 chunks +45 lines, -230 lines 0 comments Download
A src/cmd/5l/symtab.c View 1 chunk +160 lines, -0 lines 0 comments Download
M src/cmd/6l/6.out.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/6l/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/6l/asm.c View 1 2 3 4 5 12 chunks +15 lines, -43 lines 0 comments Download
M src/cmd/6l/l.h View 1 2 3 4 5 15 chunks +18 lines, -46 lines 0 comments Download
M src/cmd/6l/list.c View 1 2 3 4 5 3 chunks +12 lines, -7 lines 0 comments Download
M src/cmd/6l/obj.c View 1 2 3 14 chunks +36 lines, -337 lines 0 comments Download
M src/cmd/6l/pass.c View 1 2 3 4 5 22 chunks +108 lines, -377 lines 0 comments Download
A src/cmd/6l/prof.c View 1 chunk +171 lines, -0 lines 0 comments Download
M src/cmd/6l/span.c View 1 2 3 4 5 15 chunks +113 lines, -385 lines 0 comments Download
A src/cmd/6l/symtab.c View 6 1 chunk +246 lines, -0 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/8l/Makefile View 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/8l/asm.c View 12 chunks +20 lines, -46 lines 0 comments Download
M src/cmd/8l/l.h View 1 2 14 chunks +19 lines, -43 lines 0 comments Download
M src/cmd/8l/list.c View 3 chunks +12 lines, -7 lines 0 comments Download
M src/cmd/8l/obj.c View 15 chunks +35 lines, -283 lines 0 comments Download
M src/cmd/8l/optab.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/8l/pass.c View 21 chunks +104 lines, -355 lines 0 comments Download
A src/cmd/8l/prof.c View 1 chunk +173 lines, -0 lines 0 comments Download
M src/cmd/8l/span.c View 12 chunks +68 lines, -311 lines 0 comments Download
A src/cmd/8l/symtab.c View 6 1 chunk +164 lines, -0 lines 0 comments Download
M src/cmd/ld/dwarf.c View 1 2 3 4 5 7 chunks +14 lines, -21 lines 0 comments Download
M src/cmd/ld/elf.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/ld/go.c View 1 2 3 4 5 4 chunks +65 lines, -14 lines 0 comments Download
M src/cmd/ld/lib.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 1 2 3 4 5 8 chunks +48 lines, -62 lines 0 comments Download
M src/cmd/ld/macho.c View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/debug/gosym/pclinetest.s View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello ken2, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-10-07 15:17:00 UTC) #1
rsc
... http://codereview.appspot.com/2335043/ Looking for comments before applying same changes to 5l, 8l. All tests pass ...
15 years ago (2010-10-07 15:20:29 UTC) #2
ken3
lgtm
15 years ago (2010-10-08 20:20:43 UTC) #3
rsc
Added 5l, 8l to this CL (have to keep in sync with ld directory).
15 years ago (2010-10-13 19:47:48 UTC) #4
rsc
15 years ago (2010-10-13 19:51:25 UTC) #5
*** Submitted as 6320f16de5c9 ***

5l, 6l, 8l: first pass cleanup

* Maintain Sym* list for text with individual
  prog lists instead of using one huge list and
  overloading p->pcond.
* Comment what each file is for.
* Move some output code from span.c to asm.c.
* Move profiling into prof.c, symbol table into symtab.c.
* Move mkfwd to ld/lib.c.
* Throw away dhog dynamic loading code.
* Throw away Alef become.
* Fix printing of WORD instructions in 5l -a.

Goal here is to be able to handle each piece of text or data
as a separate piece, both to make it easier to load the
occasional .o file and also to make it possible to split the
work across multiple threads.

R=ken2, r, ken3
CC=golang-dev
http://codereview.appspot.com/2335043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b