Issue 2329045: Simplify AltGr handling.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2329045: Simplify AltGr handling. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Daiki Ueno

Modified:
13 years, 6 months ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus-m17n.git

Visibility:
Public.

Description

Simplify AltGr handling. A keyboard with AltGr key should handle 4 shift levels: (1) no modifier keys are held (2) Shift key is pressed (3) AltGr key is pressed (4) both Shift and AltGr keys are pressed However, ibus-m17n currently can only handle 1-3. This patch simplifies the code and allows ibus-m17n to handle 4. BUG=none TEST=manual

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -9 lines)			Patch
	M	src/engine.c	View		2 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

Hi, This is an update for: http://codereview.appspot.com/2304041/ This patch is currently included in ibus-m17n Fedora ...

13 years, 6 months ago (2010-10-07 06:39:18 UTC) #1

Peng Huang

13 years, 6 months ago (2010-10-27 06:51:29 UTC) #2

On 2010/10/07 06:39:18, daiki.ueno wrote:
> Hi,
> 
> This is an update for:
> http://codereview.appspot.com/2304041/
> 
> This patch is currently included in ibus-m17n Fedora package and confirmed it
> working by Indic people.
> 
> Regards,

LGTM. Thanks.

Expand All Messages | Collapse All Messages