Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(505)

Issue 2304041: Treat AltGr+Shift different from AltGr. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Daiki Ueno
Modified:
13 years, 6 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus-m17n.git
Visibility:
Public.

Description

Treat AltGr+Shift different from AltGr. According to Indic users, there should be 4 shift levels of keyboard symbols: (1) no modifier keys are held (2) Shift key is pressed (3) AltGr key is pressed (4) both Shift and AltGr keys are pressed Previously ibus-m17n only recognizes 1-3. This patch enables the 4th case. BUG=none TEST=manual

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M src/engine.c View 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Daiki Ueno
13 years, 7 months ago (2010-09-29 09:21:22 UTC) #1
Daiki Ueno
13 years, 7 months ago (2010-10-05 06:19:34 UTC) #2
On 2010/09/29 09:21:22, daiki.ueno wrote:

Sorry, this patch causes a regression bug:
https://bugzilla.redhat.com/show_bug.cgi?id=639963

It turns out that the current limitation of Shift+AltGr handling can be removed
by polishing the previous commits 47b6516c, 42f59506, and 991750d.  I'll post a
new patch soon.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b