Issue 2322045: code review 2322045: re2: fix (?i)[[:^lower:]] and (?i)\W

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2322045: code review 2322045: re2: fix (?i)[[:^lower:]] and (?i)\W (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by rsc

Modified:
15 years, 8 months ago

Reviewers:

CC:
r, re2-dev_googlegroups.com

Visibility:
Public.

Patch Set 2 : code review 2322045: re2: fix (?i)[[:^lower:]] and (?i)\W #

Patch Set 3 : code review 2322045: re2: fix (?i)[[:^lower:]] and (?i)\W #

Total comments: 1

Patch Set 4 : code review 2322045: re2: fix (?i)[[:^lower:]] and (?i)\W #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -337 lines)			Patch
M	re2/make_perl_groups.pl	View		3 chunks	+9 lines, -27 lines	0 comments	Download
M	re2/make_unicode_groups.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	re2/parse.cc	View	1 2 3	8 chunks	+44 lines, -35 lines	0 comments	Download
M	re2/perl_groups.cc	View		1 chunk	+53 lines, -143 lines	0 comments	Download
M	re2/testing/parse_test.cc	View	1	3 chunks	+19 lines, -2 lines	0 comments	Download
M	re2/testing/re2_test.cc	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	re2/unicode_groups.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	re2/unicode_groups.cc	View		1 chunk	+128 lines, -128 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: re2-dev@googlegroups.com), I'd like you to review this change.

15 years, 8 months ago (2010-10-06 09:54:22 UTC) #1

LGTM http://codereview.appspot.com/2322045/diff/5001/re2/parse.cc File re2/parse.cc (right): http://codereview.appspot.com/2322045/diff/5001/re2/parse.cc#newcode1448 re2/parse.cc:1448: // to what's already missing. Too hard, so ...

15 years, 8 months ago (2010-10-11 17:57:38 UTC) #3

rsc

15 years, 8 months ago (2010-10-11 18:06:20 UTC) #5

*** Submitted as http://code.google.com/p/re2/source/detail?r=cb51df6be426 ***

re2: fix (?i)[[:^lower:]] and (?i)\W

R=r
CC=re2-dev
http://codereview.appspot.com/2322045

Expand All Messages | Collapse All Messages