http://codereview.appspot.com/2289041/diff/1010/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2289041/diff/1010/doc/go_spec.html#newcode884 doc/go_spec.html:884: (also called an embedded field). We called them "embedded ...
13 years, 7 months ago
(2010-09-28 20:29:06 UTC)
#3
Its fine with me, but I think it will make the use of "embedded" more ...
13 years, 7 months ago
(2010-09-29 00:03:12 UTC)
#5
Its fine with me, but I think it will make the use of "embedded" more
common.
- Robert
On Tue, Sep 28, 2010 at 5:00 PM, Russ Cox <rsc@golang.org> wrote:
> I am not proposing to change the preferred name.
> The spec calls them anonymous everywhere,
> and that's consistent and good.
>
> However, they do get referred to as "embedded"
> in other prominent documents and discussions,
> despite previous efforts to eliminate use of that
> term. This change adds exactly one instance
> of that word only so that someone who visits the
> spec and does a text search for "embed" or
> "embedded" will find the right section.
>
> Is that okay to leave in?
>
> Russ
>
I am not proposing to change the preferred name. The spec calls them anonymous everywhere, ...
13 years, 7 months ago
(2010-09-29 00:58:44 UTC)
#9
I am not proposing to change the preferred name.
The spec calls them anonymous everywhere,
and that's consistent and good.
However, they do get referred to as "embedded"
in other prominent documents and discussions,
despite previous efforts to eliminate use of that
term. This change adds exactly one instance
of that word only so that someone who visits the
spec and does a text search for "embed" or
"embedded" will find the right section.
Is that okay to leave in?
Russ
LGTM On Tue, Sep 28, 2010 at 12:29 PM, <rsc@golang.org> wrote: > Reviewers: gri, iant, ...
13 years, 7 months ago
(2010-09-29 03:49:42 UTC)
#10
LGTM
On Tue, Sep 28, 2010 at 12:29 PM, <rsc@golang.org> wrote:
> Reviewers: gri, iant, ken2, r,
>
> Message:
> Hello gri, iant, ken2, r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> gc, spec, tests: no auto-indirect of pointer to interface value
>
> Implies no embedding of pointer to interface value either.
>
> Please review this at http://codereview.appspot.com/2289041/
>
> Affected files:
> M doc/go_spec.html
> M src/cmd/gc/dcl.c
> M src/cmd/gc/reflect.c
> M src/cmd/gc/typecheck.c
> M test/hashmap.go
> M test/interface/embed.go
> M test/interface/embed2.go
> M test/method.go
> M test/method2.go
>
>
>
*** Submitted as 54014073d377 *** gc, spec, tests: no auto-indirect of pointer to interface value ...
13 years, 7 months ago
(2010-09-30 18:59:46 UTC)
#11
*** Submitted as 54014073d377 ***
gc, spec, tests: no auto-indirect of pointer to interface value
Implies no embedding of pointer to interface value either.
R=gri, iant, ken2, r, r2
CC=golang-dev
http://codereview.appspot.com/2289041
Issue 2289041: code review 2289041: gc, spec, tests: no auto-indirect of pointer to interfa...
(Closed)
Created 13 years, 7 months ago by rsc
Modified 5 years, 4 months ago
Reviewers:
Base URL:
Comments: 4