Issue 2249045: code review 2249045: asn1: make interface consistent with json

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2249045: code review 2249045: asn1: make interface consistent with json (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

asn1: make interface consistent with json Replace Marshal with MarshalToMemory (no one was using old Marshal anyway). Swap arguments to Unmarshal. Fixes issue 1133.

Patch Set 1 #

Patch Set 2 : code review 2249045: asn1: make interface consistent with json #

Patch Set 3 : code review 2249045: asn1: make interface consistent with json #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -42 lines)			Patch
M	src/pkg/asn1/asn1.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/asn1/asn1_test.go	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/asn1/marshal.go	View		1 chunk	+4 lines, -14 lines	0 comments	Download
M	src/pkg/asn1/marshal_test.go	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View	1	19 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-09-24 16:28:55 UTC) #1

rsc

14 years, 7 months ago (2010-09-24 16:34:20 UTC) #3

*** Submitted as 38e013ca9bfc ***

asn1: make interface consistent with json

Replace Marshal with MarshalToMemory
(no one was using old Marshal anyway).

Swap arguments to Unmarshal.

Fixes issue 1133.

R=agl1
CC=golang-dev
http://codereview.appspot.com/2249045

Expand All Messages | Collapse All Messages