Issue 2247044: code review 2247044: misc/dashboard/builder: fixes and improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2247044: code review 2247044: misc/dashboard/builder: fixes and improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by adg

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

misc/dashboard/builder: fixes and improvements - fix release upload - add -rev= flag to build specific revision and exit - added support for all-$GOARCH.bash

Patch Set 2 : code review 2247044: misc/dashboard/builder: fixes and improvements #

Total comments: 2

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -36 lines)			Patch
	M	misc/dashboard/builder/main.go	View		6 chunks	+58 lines, -36 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-09-21 03:35:04 UTC) #1

rsc1

LGTM http://codereview.appspot.com/2247044/diff/2001/misc/dashboard/builder/main.go File misc/dashboard/builder/main.go (right): http://codereview.appspot.com/2247044/diff/2001/misc/dashboard/builder/main.go#newcode42 misc/dashboard/builder/main.go:42: buildRelease = flag.Bool("release", false, "Build and deliver binary ...

14 years, 9 months ago (2010-09-21 09:50:17 UTC) #2

adg

14 years, 9 months ago (2010-09-21 10:32:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=05f99c12564f ***

misc/dashboard/builder: fixes and improvements

- fix release upload
- add -rev= flag to build specific revision and exit
- added support for all-$GOARCH.bash

R=rsc
CC=golang-dev
http://codereview.appspot.com/2247044

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages