code review 2246041: gob: make robust when decoding a struct with non-struct...

gob: make robust when decoding a struct with non-struct data.
The decoder was crashing when handling an rpc that expected
a struct but was delivered something else.  This diagnoses the
problem.  The other direction (expecting non-struct but getting
one) was already handled.

[r, 2010-09-19 00:41:57]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-19 15:01:06]

LGTM

http://codereview.appspot.com/2246041/diff/1/src/pkg/gob/decode.go
File src/pkg/gob/decode.go (right):

http://codereview.appspot.com/2246041/diff/1/src/pkg/gob/decode.go#newcode847
src/pkg/gob/decode.go:847: // Also we know we;re decoding a struct now, so the
client must have sent one.
s/;/'/

[r, 2010-09-19 21:37:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=149e961a8408 ***

gob: make robust when decoding a struct with non-struct data.
The decoder was crashing when handling an rpc that expected
a struct but was delivered something else.  This diagnoses the
problem.  The other direction (expecting non-struct but getting
one) was already handled.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2246041