Issue 2245041: code review 2245041: netchan: handle closing of channels.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2245041: code review 2245041: netchan: handle closing of channels. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by r

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

netchan: handle closing of channels. This also silences some misleading logging. Also improve logging.

Patch Set 1 #

Patch Set 2 : code review 2245041: netchan: handle closing of channels. #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -45 lines)			Patch
M	src/pkg/netchan/common.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/netchan/export.go	View	9 chunks	+32 lines, -11 lines	0 comments	Download
M	src/pkg/netchan/import.go	View	5 chunks	+43 lines, -17 lines	0 comments	Download
M	src/pkg/netchan/netchan_test.go	View	7 chunks	+41 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-09-18 22:25:17 UTC) #1

14 years, 10 months ago (2010-09-20 00:14:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=930ae3132752 ***

netchan: handle closing of channels.
This also silences some misleading logging.
Also improve logging.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2245041

Expand All Messages | Collapse All Messages