http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c File src/pkg/syscall/types_linux.c (right): http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c... src/pkg/syscall/types_linux.c:124: typedef struct inotify_event $RawInotifyEvent; s/Raw// Unless package syscall is going to define a separate InotifyEvent (unlikely) this can be called just InotifyEvent. The use of Raw above for the sockaddrs is because there is a machine-independent sockaddr for each of the raw ones. This isn't typical (for example Linger, Iovec, Utsname, etc). http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c... src/pkg/syscall/types_linux.c:127: $SizeofRawInotifyEvent = sizeof(struct inotify_event) s/Raw//
http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c File src/pkg/syscall/types_linux.c (right): http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c... src/pkg/syscall/types_linux.c:124: typedef struct inotify_event $RawInotifyEvent; On 2010/09/27 13:29:55, rsc1 wrote: > s/Raw// > > Unless package syscall is going to define a separate InotifyEvent > (unlikely) this can be called just InotifyEvent. The use of Raw above > for the sockaddrs is because there is a machine-independent > sockaddr for each of the raw ones. This isn't typical (for example > Linger, Iovec, Utsname, etc). > Makes sense. Fixed. http://codereview.appspot.com/2241045/diff/8001/src/pkg/syscall/types_linux.c... src/pkg/syscall/types_linux.c:127: $SizeofRawInotifyEvent = sizeof(struct inotify_event) On 2010/09/27 13:29:55, rsc1 wrote: > s/Raw// > Fixed.
*** Submitted as 1ed14c9ace3f *** syscall: add inotify on Linux R=rsc CC=golang-dev http://codereview.appspot.com/2241045 Committer: Russ Cox <rsc@golang.org>