Enhancement: tabalture chord repetition

Enhancement: tabalture chord repetition

For better use with tablature, a new tab-repeat-chord function
is provided which takes care of the string information
(thanks to Nicolas Sceaux!). A new command \tabChordRepetition
is also included to switch to this new repetition style.

[nicolas.sceaux, 2010-02-28 16:27:07]

http://codereview.appspot.com/224082/diff/1/3
File ly/chord-repetition-init.ly (right):

http://codereview.appspot.com/224082/diff/1/3#newcode51
ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord previous-chord
location duration articulations)
It would be  better to define a generic repetition function, taking the event
types that should be kept for NoteEvents. default-repeat-chord and
tab-repeat-chord would then use this function.  I'm writing it on other post.

[nicolas.sceaux, 2010-02-28 17:29:57]

On 2010/02/28 16:27:07, nicolas.sceaux wrote:
> http://codereview.appspot.com/224082/diff/1/3
> File ly/chord-repetition-init.ly (right):
> 
> http://codereview.appspot.com/224082/diff/1/3#newcode51
> ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
previous-chord
> location duration articulations)
> It would be  better to define a generic repetition function, taking the event
> types that should be kept for NoteEvents. default-repeat-chord and
> tab-repeat-chord would then use this function.  I'm writing it on other post.


#(define-public ((make-repeat-chord-function chord-element-types
note-articulation-types)
                 previous-chord location duration articulations)
   "Make a chord repetition function.
The returned functions copies the notes from @var{previous-chord} into
a new chord.
Chord elements, which type is found in @var{chord-element-types}, are
copied into the new chord.
Note articulations, which type is found in @var {note-articulation-types},
are also copied.
All other events are not copied into the new chord.
"
   (define (filter-events events event-types)
     (filter (lambda (event)
               (and (memq (ly:music-property event 'name) event-types) event))
             events))
   ;; If previous-chord has an length property, then it means that it
   ;; has been processed by a music iterator.  In other words, the chord
   ;; has been memorized from an other music block, which is certainly not
   ;; what the user has intended, as anywy the result will be buggy.
   ;; In that case, raise a warning.
   (if (not (and (ly:music? previous-chord)
                 (null? (ly:music-property previous-chord 'length))))
       (ly:input-message location
                         (_ "No memorized chord in music block before chord
repetition")))
   ;; Instead of copying the previous chord, then removing the
   ;; undesired elements (like articulations), a new empty chord is built.
   ;; Then, the pitch found in the previous chord are added to the new
   ;; chord, without any "decoration" (e.g. cautionary accidentals,
   ;; fingerings, text scripts, articulations).  Only the events of types
   ;; given in `chord-elements-types' and `note-articulation-types' are
   ;; copied from the original chord elements and note articulations,
   ;; respectively.
   (let ((elements (ly:music-property (ly:music-deep-copy previous-chord)
'elements)))
     (make-music
      'EventChord
      'origin location
      'elements (append!
                 (map (lambda (note)
                        (let ((new-note (make-music 'NoteEvent
                                                    'pitch (ly:music-property
note 'pitch)
                                                    'duration duration))
                              (articulations
                               (filter-events (ly:music-property note
'articulations)
                                              note-articulation-types)))
                          (if (not (null? articulations))
                              (set! (ly:music-property new-note 'articulations)
                                    articulations))
                          new-note))
                      (filter-events elements '(NoteEvent)))
                 (filter-events elements chord-element-types)
                 articulations))))

#(define-public default-repeat-chord
   (make-repeat-chord-function '() '()))

#(define-public tab-repeat-chord
   (make-repeat-chord-function '(StringNumberEvent) '(StringNumberEvent)))

[marc, 2010-03-01 09:00:55]

nicolas.sceaux@gmail.com schrieb:
>
> http://codereview.appspot.com/224082/diff/1/3
> File ly/chord-repetition-init.ly (right):
>
> http://codereview.appspot.com/224082/diff/1/3#newcode51
> ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
> previous-chord location duration articulations)
> It would be  better to define a generic repetition function, taking the
> event types that should be kept for NoteEvents. default-repeat-chord and
> tab-repeat-chord would then use this function.  I'm writing it on other
> post.
Done. Thanks for this improvement!

Marc

http://codereview.appspot.com/224082/show

[nicolas.sceaux, 2010-03-01 10:01:54]

Le 1 mars 2010 à 10:00, Marc Hohl a écrit :

> nicolas.sceaux@gmail.com schrieb:
>> 
>> http://codereview.appspot.com/224082/diff/1/3
>> File ly/chord-repetition-init.ly (right):
>> 
>> http://codereview.appspot.com/224082/diff/1/3#newcode51
>> ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
>> previous-chord location duration articulations)
>> It would be  better to define a generic repetition function, taking the
>> event types that should be kept for NoteEvents. default-repeat-chord and
>> tab-repeat-chord would then use this function.  I'm writing it on other
>> post.
> Done. Thanks for this improvement!
> 
> Marc
> 
> http://codereview.appspot.com/224082/show

Shouldn't there be a few words of explantion about using q and
\tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
strings"?

Apart from that, it's ok AFAICT.

nicolas

[marc, 2010-03-01 11:07:30]

Nicolas Sceaux schrieb:
> Le 1 mars 2010 à 10:00, Marc Hohl a écrit :
>
>   
>> nicolas.sceaux@gmail.com schrieb:
>>     
>>> http://codereview.appspot.com/224082/diff/1/3
>>> File ly/chord-repetition-init.ly (right):
>>>
>>> http://codereview.appspot.com/224082/diff/1/3#newcode51
>>> ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
>>> previous-chord location duration articulations)
>>> It would be  better to define a generic repetition function, taking the
>>> event types that should be kept for NoteEvents. default-repeat-chord and
>>> tab-repeat-chord would then use this function.  I'm writing it on other
>>> post.
>>>       
>> Done. Thanks for this improvement!
>>
>> Marc
>>
>> http://codereview.appspot.com/224082/show
>>     
>
> Shouldn't there be a few words of explantion about using q and
> \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
> strings"?
>   
I'll have a look at it.

Thanks,

Marc
> Apart from that, it's ok AFAICT.
>
> nicolas
>
>
>   

[nicolas.sceaux, 2010-03-02 10:59:48]

Le 1 mars 2010 à 20:24, Marc Hohl a écrit :

> Nicolas Sceaux schrieb:
>> 
>> Shouldn't there be a few words of explantion about using q and
>> \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
>> strings"?
>>  
> Done. I hope it is ok.
> 
> Marc
> 
> http://codereview.appspot.com/224082/show

Looks OK.

[marc, 2010-03-02 11:08:45]

Nicolas Sceaux schrieb:
> Le 1 mars 2010 à 10:00, Marc Hohl a écrit :
>
>   
>> nicolas.sceaux@gmail.com schrieb:
>>     
>>> http://codereview.appspot.com/224082/diff/1/3
>>> File ly/chord-repetition-init.ly (right):
>>>
>>> http://codereview.appspot.com/224082/diff/1/3#newcode51
>>> ly/chord-repetition-init.ly:51: #(define-public (tab-repeat-chord
>>> previous-chord location duration articulations)
>>> It would be  better to define a generic repetition function, taking the
>>> event types that should be kept for NoteEvents. default-repeat-chord and
>>> tab-repeat-chord would then use this function.  I'm writing it on other
>>> post.
>>>       
>> Done. Thanks for this improvement!
>>
>> Marc
>>
>> http://codereview.appspot.com/224082/show
>>     
>
> Shouldn't there be a few words of explantion about using q and
> \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
> strings"?
>   
Done. I hope it is ok.

Marc

http://codereview.appspot.com/224082/show

[marc, 2010-03-02 11:26:03]

Nicolas Sceaux schrieb:
> Le 1 mars 2010 à 20:24, Marc Hohl a écrit :
>
>   
>> Nicolas Sceaux schrieb:
>>     
>>> Shouldn't there be a few words of explantion about using q and
>>> \tabChordRepetition somewhere in 2.4.1 "Common notation for fretted
>>> strings"?
>>>  
>>>       
>> Done. I hope it is ok.
>>
>> Marc
>>
>> http://codereview.appspot.com/224082/show
>>     
>
> Looks OK.
>   
Thanks. Can you please push it? I am not allowed to...

Greetings

Marc

[Neil Puttock, 2010-03-14 22:15:23]

Hi Marc,

Here are a few more comments for you.

Cheers,
Neil

http://codereview.appspot.com/224082/diff/1012/17
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/224082/diff/1012/17#newcode256
Documentation/notation/fretted-strings.itely:256: is provided. It preserves the
string information explicitly given within
provided.  It

http://codereview.appspot.com/224082/diff/1012/17#newcode259
Documentation/notation/fretted-strings.itely:259:
@lilypond[quote,ragged-right,verbatim]
[quote,verbatim]

http://codereview.appspot.com/224082/diff/1012/18
File input/regression/tablature-chord-repetition.ly (right):

http://codereview.appspot.com/224082/diff/1012/18#newcode1
input/regression/tablature-chord-repetition.ly:1: \version "2.13.15"
"2.13.16"

http://codereview.appspot.com/224082/diff/1012/18#newcode3
input/regression/tablature-chord-repetition.ly:3: \header{ texidoc = "In a
TabStaff, the chord repetition function needs
\header {
  texidoc =

}

http://codereview.appspot.com/224082/diff/1012/19
File ly/chord-repetition-init.ly (right):

http://codereview.appspot.com/224082/diff/1012/19#newcode71
ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '()))
indent

#(define
   (make

http://codereview.appspot.com/224082/diff/1012/19#newcode74
ly/chord-repetition-init.ly:74: (make-repeat-chord-function '(StringNumberEvent)
'(StringNumberEvent)))
indent

http://codereview.appspot.com/224082/diff/1012/20
File ly/property-init.ly (right):

http://codereview.appspot.com/224082/diff/1012/20#newcode384
ly/property-init.ly:384: tabChordRepetition =
move to music-functions-init.ly

http://codereview.appspot.com/224082/diff/1012/20#newcode386
ly/property-init.ly:386: (ly:parser-set-repetition-function parser
tab-repeat-chord)
docstring above this line

(_i "Docme.")

[marc, 2010-03-15 09:53:31]

n.puttock@gmail.com schrieb:
> Hi Marc,
>
> Here are a few more comments for you.
>
> Cheers,
> Neil
>
>
>
> http://codereview.appspot.com/224082/diff/1012/17
> File Documentation/notation/fretted-strings.itely (right):
>
> http://codereview.appspot.com/224082/diff/1012/17#newcode256
> Documentation/notation/fretted-strings.itely:256: is provided. It
> preserves the string information explicitly given within
> provided.  It
Ok. I found some spacing errors in the lines above, so I changed them 
accordingly.
>
> http://codereview.appspot.com/224082/diff/1012/17#newcode259
> Documentation/notation/fretted-strings.itely:259:
> @lilypond[quote,ragged-right,verbatim]
> [quote,verbatim]
Done.
>
> http://codereview.appspot.com/224082/diff/1012/18
> File input/regression/tablature-chord-repetition.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/18#newcode1
> input/regression/tablature-chord-repetition.ly:1: \version "2.13.15"
> "2.13.16"
Done.
>
> http://codereview.appspot.com/224082/diff/1012/18#newcode3
> input/regression/tablature-chord-repetition.ly:3: \header{ texidoc = "In
> a TabStaff, the chord repetition function needs
> \header {
>   texidoc =
>
> }
Ok.
>
> http://codereview.appspot.com/224082/diff/1012/19
> File ly/chord-repetition-init.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/19#newcode71
> ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '()))
> indent
>
> #(define
>    (make
Ok, but I thought that 2 spaces is the right indentation, no?
By the way, that's not consistent in ly/music-functions-init.ly, either.
>
> http://codereview.appspot.com/224082/diff/1012/19#newcode74
> ly/chord-repetition-init.ly:74: (make-repeat-chord-function
> '(StringNumberEvent) '(StringNumberEvent)))
> indent
Ok (see above).
>
> http://codereview.appspot.com/224082/diff/1012/20
> File ly/property-init.ly (right):
>
> http://codereview.appspot.com/224082/diff/1012/20#newcode384
> ly/property-init.ly:384: tabChordRepetition =
> move to music-functions-init.ly
Done.
>
> http://codereview.appspot.com/224082/diff/1012/20#newcode386
> ly/property-init.ly:386: (ly:parser-set-repetition-function parser
> tab-repeat-chord)
> docstring above this line
>
> (_i "Docme.")
Done. I hope the Docstring is ok.

Thanks for your comments!

Marc

http://codereview.appspot.com/224082/show

[Neil Puttock, 2010-03-16 23:11:11]

On 2010/03/15 09:53:31, marc wrote:

> > http://codereview.appspot.com/224082/diff/1012/19
> > File ly/chord-repetition-init.ly (right):
> >
> > http://codereview.appspot.com/224082/diff/1012/19#newcode71
> > ly/chord-repetition-init.ly:71: (make-repeat-chord-function '() '()))
> > indent
> >
> > #(define
> >    (make
> Ok, but I thought that 2 spaces is the right indentation, no?

Yes, but only for .ly files which contain LilyPond snippets.

In the case of music-functions-init.ly, it's all scheme, so it should follow
scheme indentation.

> By the way, that's not consistent in ly/music-functions-init.ly, either.

True, though it will be once I've finished with it. ;)
 
> Thanks for your comments!

No problem.

I'll apply the patch soon.

Cheers,
Neil