Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1329)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 224062: code review 224062: strings: delete Runes, Bytes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by rsc
Modified:
14 years, 2 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

strings: delete Runes, Bytes gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench delete unused imports

Patch Set 1 #

Patch Set 2 : code review 224062: strings: delete Runes, Bytes #

Patch Set 3 : code review 224062: strings: delete Runes, Bytes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -310 lines) Patch
M src/cmd/cgo/gcc.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/ebnflint/ebnflint.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/cmd/godoc/godoc.go View 10 chunks +13 lines, -13 lines 0 comments Download
M src/cmd/godoc/index.go View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/snippet.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/godoc/spec.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/archive/tar/reader_test.go View 1 3 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/archive/tar/writer.go View 1 3 chunks +16 lines, -17 lines 0 comments Download
M src/pkg/asn1/asn1_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/asn1/marshal.go View 1 3 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bytes/bytes_test.go View 1 11 chunks +14 lines, -15 lines 0 comments Download
M src/pkg/compress/gzip/gzip_test.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/crypto/hmac/hmac_test.go View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15_test.go View 1 5 chunks +6 lines, -7 lines 0 comments Download
M src/pkg/crypto/tls/handshake_messages.go View 1 4 chunks +3 lines, -5 lines 0 comments Download
M src/pkg/crypto/tls/prf.go View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/pkg/crypto/x509/x509.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/x509/x509_test.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/ebnf/ebnf_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/encoding/ascii85/ascii85_test.go View 1 5 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/encoding/base64/base64_test.go View 1 5 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/encoding/git85/git_test.go View 1 5 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/encoding/hex/hex.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/encoding/pem/pem.go View 1 4 chunks +6 lines, -7 lines 0 comments Download
M src/pkg/encoding/pem/pem_test.go View 1 6 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/exp/datafmt/datafmt_test.go View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/exp/datafmt/parser.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/spacewar/spacewar.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/go/doc/comment.go View 2 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/go/parser/interface.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/go/printer/nodes.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/go/printer/printer.go View 1 6 chunks +11 lines, -12 lines 0 comments Download
M src/pkg/go/scanner/scanner_test.go View 1 9 chunks +8 lines, -9 lines 0 comments Download
M src/pkg/gob/codec_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/http/client.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/lex.go View 1 2 chunks +1 line, -5 lines 0 comments Download
M src/pkg/http/request.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/url.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/io/io.go View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/pkg/io/ioutil/ioutil_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/io/pipe_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/net/dialgoogle_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/net/server_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/os_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/patch/patch_test.go View 1 3 chunks +3 lines, -6 lines 0 comments Download
M src/pkg/path/path.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/regexp/all_test.go View 5 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/strings/strings.go View 1 chunk +0 lines, -20 lines 0 comments Download
M src/pkg/strings/strings_test.go View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/template/format.go View 1 2 chunks +5 lines, -6 lines 0 comments Download
M src/pkg/template/template.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/template/template_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/testing/regexp_test.go View 1 4 chunks +3 lines, -7 lines 0 comments Download
M src/pkg/utf8/utf8_test.go View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/websocket/websocket_test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/xgb/xgb.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/xml/xml.go View 2 chunks +6 lines, -6 lines 0 comments Download
M src/pkg/xml/xml_test.go View 1 2 2 chunks +38 lines, -37 lines 0 comments Download
M test/bench/chameneosredux.go View 1 chunk +1 line, -1 line 0 comments Download
M test/bench/fasta.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/bench/k-nucleotide.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M test/bench/meteor-contest.go View 1 chunk +1 line, -1 line 0 comments Download
M test/bench/regex-dna.go View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2010-02-25 23:49:56 UTC) #1
r2
LGTM
14 years, 2 months ago (2010-02-25 23:58:56 UTC) #2
rsc
14 years, 2 months ago (2010-02-26 00:01:32 UTC) #3 
*** Submitted as http://code.google.com/p/go/source/detail?r=1a4159c225da ***

strings: delete Runes, Bytes

gofmt -w -r 'strings.Bytes(a) -> []byte(a)' src/cmd src/pkg test/bench
gofmt -w -r 'strings.Runes(a) -> []int(a)' src/cmd src/pkg test/bench
delete unused imports

R=r
CC=golang-dev
http://codereview.appspot.com/224062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b