Fix problem with Expression.fold changing meaning of code.

There are a number of places in the ES spec where the meaning of a
code construct is dependent on the context in which it appears.

Specifically,
  eval
and
  foo.bar
both have different meanings when they appear are the first operand to
the function call operator.


Submitted @3999

[Mark S. Miller, 2010-02-25 23:37:42]

On Thu, Feb 25, 2010 at 12:00 PM, <mikesamuel@gmail.com> wrote:

> Reviewers: metaweta,
>
> Description:
> There are a number of places in the ES spec where the meaning of a
> code construct is dependent on the context in which it appears.
>
> Specifically,
>  eval
> and
>  foo.bar
> both have different meanings when they appear are the first operand to
> the function call operator.
>

So does foo[bar]


>
> Please review this at http://codereview.appspot.com/224054/show
>
> Affected files:
>  M     src/com/google/caja/ancillary/opt/JsOptimizer.java
>  M     src/com/google/caja/ancillary/opt/ParseTreeKB.java
>  M     src/com/google/caja/ancillary/opt/StatementSimplifier.java
>  M     src/com/google/caja/parser/js/AbstractExpression.java
>  M     src/com/google/caja/parser/js/Expression.java
>  M     src/com/google/caja/parser/js/Operation.java
>  M     tests/com/google/caja/ancillary/opt/ParseTreeKBTest.java
>  M     tests/com/google/caja/parser/js/ExpressionTest.java
>
>
>


-- 
    Cheers,
    --MarkM

[MikeSamuel, 2010-02-26 01:04:13]

2010/2/25 Mark S. Miller <erights@google.com>:
> On Thu, Feb 25, 2010 at 12:00 PM, <mikesamuel@gmail.com> wrote:
>>
>> Reviewers: metaweta,
>>
>> Description:
>> There are a number of places in the ES spec where the meaning of a
>> code construct is dependent on the context in which it appears.
>>
>> Specifically,
>>  eval
>> and
>>  foo.bar
>> both have different meanings when they appear are the first operand to
>> the function call operator.
>
> So does foo[bar]

Yep.

>>
>> Please review this at http://codereview.appspot.com/224054/show
>>
>> Affected files:
>>  M     src/com/google/caja/ancillary/opt/JsOptimizer.java
>>  M     src/com/google/caja/ancillary/opt/ParseTreeKB.java
>>  M     src/com/google/caja/ancillary/opt/StatementSimplifier.java
>>  M     src/com/google/caja/parser/js/AbstractExpression.java
>>  M     src/com/google/caja/parser/js/Expression.java
>>  M     src/com/google/caja/parser/js/Operation.java
>>  M     tests/com/google/caja/ancillary/opt/ParseTreeKBTest.java
>>  M     tests/com/google/caja/parser/js/ExpressionTest.java
>>
>>
>
>
>
> --
>     Cheers,
>     --MarkM
>

[MikeSamuel, 2010-03-02 01:23:16]

ping

[metaweta, 2010-03-02 22:22:57]

LGTM modulo the typo

http://codereview.appspot.com/224054/diff/1/6
File src/com/google/caja/parser/js/Expression.java (right):

http://codereview.appspot.com/224054/diff/1/6#newcode59
src/com/google/caja/parser/js/Expression.java:59: *     of eub-expressions, such
as the value of {@code this} in a method call
sub-expressions

[MikeSamuel, 2010-03-02 22:44:15]

http://codereview.appspot.com/224054/diff/1/6
File src/com/google/caja/parser/js/Expression.java (right):

http://codereview.appspot.com/224054/diff/1/6#newcode59
src/com/google/caja/parser/js/Expression.java:59: *     of eub-expressions, such
as the value of {@code this} in a method call
On 2010/03/02 22:22:58, metaweta wrote:
> sub-expressions

Done.