Fix for issue1703

Issue closed

[ced, 2010-09-28 13:33:14]

http://codereview.appspot.com/2237047/diff/1/invoice.py
File invoice.py (right):

http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2475
invoice.py:2475: if line_id and line_id not in line_ids:
This will always happen as line_id is a payment line.
We must find why before it was not the case.

http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2485
invoice.py:2485: if line_id and line_id not in line_ids:
This should never happen

[Sednacom, 2010-09-28 13:54:53]

http://codereview.appspot.com/2237047/diff/1/invoice.py
File invoice.py (right):

http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2485
invoice.py:2485: if line_id and line_id not in line_ids:
On 2010/09/28 13:33:14, ced wrote:
> This should never happen

Well, it was added by 'security', but you are right. We will remove this part of
the patch.

[Sednacom, 2010-09-30 10:24:10]

http://codereview.appspot.com/2237047/diff/1/invoice.py
File invoice.py (right):

http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2475
invoice.py:2475: if line_id and line_id not in line_ids:
On 2010/09/28 13:33:14, ced wrote:
> This will always happen as line_id is a payment line.
> We must find why before it was not the case.

We have checked in our databases. Payment with write-off has been used only one
time before, 9 months ago on a 1.4 server, and it seems it worked nice at this
time.
Many things have occured in code since. It will be hard to find why this problem
appears now.

[ced, 2010-10-01 19:23:24]

On 2010/09/30 10:24:10, Sednacom wrote:
> http://codereview.appspot.com/2237047/diff/1/invoice.py
> File invoice.py (right):
> 
> http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2475
> invoice.py:2475: if line_id and line_id not in line_ids:
> On 2010/09/28 13:33:14, ced wrote:
> > This will always happen as line_id is a payment line.
> > We must find why before it was not the case.
> 
> We have checked in our databases. Payment with write-off has been used only
one
> time before, 9 months ago on a 1.4 server, and it seems it worked nice at this
> time.
> Many things have occured in code since. It will be hard to find why this
problem
> appears now.

For me the issue was introduced in the changeset 9654b3ad3f5b (which was done
for 1.4.0).
The value of the field payment_lines of invoice was read before the call to
pay_invoice which create line_id. So before the changeset the value of
payment_lines did not included line_id but with the changeset the field is
re-computed and then it is included.

[ced, 2010-10-01 19:24:30]

http://codereview.appspot.com/2237047/diff/1/invoice.py
File invoice.py (right):

http://codereview.appspot.com/2237047/diff/1/invoice.py#newcode2476
invoice.py:2476: line_ids += [line_id]
This line must be removed.

[ced, 2010-10-01 21:18:07]

I made a test on 1.4 and the bug is also present.

[ced, 2010-10-01 21:28:20]

Can be closed.