Issue 2237043: code review 2237043: test: fix NaCl build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2237043: code review 2237043: test: fix NaCl build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:
nigeltao_gnome

CC:
r, golang-dev

Visibility:
Public.

Description

test: fix NaCl build Wasn't running the temp binary under $E (emulator).

Patch Set 1 #

Patch Set 2 : code review 2237043: test: fix NaCl build #

Patch Set 3 : code review 2237043: test: fix NaCl build #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	test/index.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/run	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-09-20 02:56:10 UTC) #1

rsc

FYI After this CL, the NaCl build runs to completion except for exp/nacl/av. Russ

14 years, 7 months ago (2010-09-20 02:57:03 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=5ccb77abd89d *** test: fix NaCl build Wasn't running the temp binary under ...

14 years, 7 months ago (2010-09-20 03:28:38 UTC) #3

nigeltao_gnome

14 years, 7 months ago (2010-09-20 03:34:32 UTC) #4

On 20 September 2010 12:56, Russ Cox <rsc@golang.org> wrote:
> After this CL, the NaCl build runs to completion
> except for exp/nacl/av.

I'm working on a fix.

Expand All Messages | Collapse All Messages