Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(497)

Issue 223054: code review 223054: go/printer, gofmt: correct indentation after certain /*... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by gri
Modified:
15 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/printer, gofmt: correct indentation after certain /*-style comments - applied gofmt to src and misc Note: This fix improved formatting of src/pkg/math/all_test.go but leads to a degradation in src/pkg/exp/4s/xs.go. The latter happened to "work" before accidentally. Fixing the alignment in that case in general will be a separate CL. Fixes issue 628.

Patch Set 1 #

Patch Set 2 : code review 223054: go/printer, gofmt: correct indentation after certain /*... #

Patch Set 3 : code review 223054: go/printer, gofmt: correct indentation after certain /*... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M src/pkg/exp/4s/xs.go View 1 chunk +7 lines, -7 lines 0 comments Download
M src/pkg/go/printer/printer.go View 9 chunks +33 lines, -26 lines 0 comments Download
M src/pkg/go/printer/testdata/comments.golden View 2 chunks +6 lines, -1 line 0 comments Download
M src/pkg/go/printer/testdata/comments.input View 2 chunks +6 lines, -1 line 0 comments Download
M src/pkg/math/all_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 5 months ago (2010-02-25 21:35:02 UTC) #1
rsc
LGTM maybe worth changing writeNewlines to writeN(n, string) called as writeN(n, newlines) or writeN(n, formfeeds) ...
15 years, 5 months ago (2010-02-25 21:41:27 UTC) #2
gri
15 years, 5 months ago (2010-02-25 21:47:18 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b935632bd132 ***

go/printer, gofmt: correct indentation after certain /*-style comments
- applied gofmt to src and misc

Note: This fix improved formatting of src/pkg/math/all_test.go but leads
to a degradation in src/pkg/exp/4s/xs.go. The latter happened to "work"
before accidentally. Fixing the alignment in that case in general will
be a separate CL.

Fixes issue 628.

R=rsc
CC=golang-dev
http://codereview.appspot.com/223054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b