Issue 223041: code review 223041: gofmt: don't print ()'s around function-typed results (...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223041: code review 223041: gofmt: don't print ()'s around function-typed results (... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by gri

Modified:
15 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gofmt: don't print ()'s around function-typed results (not needed anymore) - add extra test cases to go/printer tests - apply gofmt to src and misc

Patch Set 1 #

Patch Set 2 : code review 223041: gofmt: don't print ()'s around function-typed results (... #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -37 lines)			Patch
M	src/pkg/exp/eval/expr.go	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/exp/eval/expr1.go	View	2 chunks	+16 lines, -20 lines	0 comments	Download
M	src/pkg/exp/eval/stmt.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/iterable/iterable.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.golden	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.input	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/reflect/all_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/template/template_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 5 months ago (2010-02-24 21:17:09 UTC) #1