Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 2225048: code review 2225048: utf.String: Slice(i,j) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by r
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

utf8.String: Slice(i,j)

Patch Set 1 #

Patch Set 2 : code review 2225048: utf.String: Slice(i,j) #

Patch Set 3 : code review 2225048: utf.String: Slice(i,j) #

Total comments: 3

Patch Set 4 : code review 2225048: utf.String: Slice(i,j) #

Patch Set 5 : code review 2225048: utf8.String: Slice(i,j) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -1 line) Patch
M src/pkg/utf8/string.go View 1 2 3 3 chunks +37 lines, -1 line 0 comments Download
M src/pkg/utf8/string_test.go View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 6
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-09-24 22:03:12 UTC) #1
r
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 10 months ago (2010-09-24 22:03:29 UTC) #2
rsc1
I must be missing something about the panics. http://codereview.appspot.com/2225048/diff/7001/src/pkg/utf8/string.go File src/pkg/utf8/string.go (right): http://codereview.appspot.com/2225048/diff/7001/src/pkg/utf8/string.go#newcode71 src/pkg/utf8/string.go:71: panic(badSlice) ...
14 years, 10 months ago (2010-09-24 22:17:43 UTC) #3
r
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 10 months ago (2010-09-24 22:24:29 UTC) #4
rsc1
LGTM Add explicit test of [0:len] and [len:len] slices?
14 years, 10 months ago (2010-09-24 22:37:03 UTC) #5
r
14 years, 10 months ago (2010-09-24 22:52:41 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=5202b8b55237 ***

utf8.String: Slice(i,j)

R=rsc
CC=golang-dev
http://codereview.appspot.com/2225048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b