Issue 2221042: code review 2221042: 6l, 8l: clean up ELF code, fix NaCl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2221042: code review 2221042: 6l, 8l: clean up ELF code, fix NaCl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

6l, 8l: clean up ELF code, fix NaCl

Patch Set 1 #

Patch Set 2 : code review 2221042: 6l, 8l: clean up ELF code, fix NaCl #

Patch Set 3 : code review 2221042: 6l, 8l: clean up ELF code, fix NaCl #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+324 lines, -194 lines)			Patch
M	src/cmd/6l/asm.c	View		8 chunks	+28 lines, -74 lines	0 comments	Download
M	src/cmd/6l/pass.c	View		5 chunks	+17 lines, -0 lines	0 comments	Download
M	src/cmd/6l/span.c	View	1	6 chunks	+28 lines, -9 lines	0 comments	Download
M	src/cmd/8l/asm.c	View		9 chunks	+45 lines, -96 lines	0 comments	Download
M	src/cmd/8l/pass.c	View		4 chunks	+15 lines, -0 lines	0 comments	Download
M	src/cmd/8l/span.c	View		4 chunks	+48 lines, -11 lines	0 comments	Download
M	src/cmd/ld/dwarf.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/ld/elf.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/ld/elf.c	View		3 chunks	+80 lines, -0 lines	0 comments	Download
M	src/cmd/ld/lib.h	View		2 chunks	+34 lines, -0 lines	0 comments	Download
M	src/cmd/ld/lib.c	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/nacl/386/closure.c	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/nacl/mem.c	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-09-20 01:14:03 UTC) #1

rsc

14 years, 9 months ago (2010-09-20 02:10:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=00d74b088dde ***

6l, 8l: clean up ELF code, fix NaCl

R=r
CC=golang-dev
http://codereview.appspot.com/2221042

Expand All Messages | Collapse All Messages