Issue 2220044: Adding cookiebaseduserprefstore.js to gadgets.jar as it is also getting used

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2220044: Adding cookiebaseduserprefstore.js to gadgets.jar as it is also getting used (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by gagan.goku

Modified:
13 years, 7 months ago

Reviewers:
Paul Lindner, dev, chirag

CC:
cool-shindig-committers_googlegroups.com, anupama.dutta, zhoresh

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Adding back cookiebaseduserprefstore.js to gadgets.jar as it is also getting used in gadgets server. This is a temporary fix whereby we are just making sure that we retain all the files that are currently getting used. A better long term fix would be to move the files under container/ directory to features/ but that is not the scope of this change.

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
		java/gadgets/pom.xml	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Paul Lindner

works for me.. hope you can get your internal tests green.

13 years, 7 months ago (2010-09-16 11:06:57 UTC) #5

gagan.goku

13 years, 7 months ago (2010-09-16 16:50:47 UTC) #6

On 2010/09/16 11:06:57, Paul Lindner wrote:
> works for me..  hope you can get your internal tests green.

Thanks Paul.

Ran mvn -e clean install and committed as r997823. Congrats Gagan on your first
real commit :)

Expand All Messages | Collapse All Messages