LGTM On 25 September 2010 04:52, <rsc@golang.org> wrote: > Reviewers: adg, > > Message: > ...
14 years, 10 months ago
(2010-09-27 00:49:18 UTC)
#3
LGTM
On 25 September 2010 04:52, <rsc@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> syscall: work harder to avoid doing this ever again
>
> Please review this at http://codereview.appspot.com/2218044/
>
> Affected files:
> M src/pkg/syscall/mksyscall.sh
>
>
> Index: src/pkg/syscall/mksyscall.sh
> ===================================================================
> --- a/src/pkg/syscall/mksyscall.sh
> +++ b/src/pkg/syscall/mksyscall.sh
> @@ -77,6 +77,11 @@
> my @in = parseparamlist($in);
> my @out = parseparamlist($out);
>
> + # Try in vain to keep people from editing this file.
> + # The theory is that they jump into the middle of the file
> + # without reading the header.
> + $text .= "// THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO
> NOT EDIT\n\n";
> +
> # Go function header.
> my $out_decl = @out ? sprintf(" (%s)", join(', ', @out)) : "";
> $text .= sprintf "func %s(%s)%s {\n", $func, join(', ', @in),
> $out_decl;
>
>
>
Issue 2218044: code review 2218044: syscall: work harder to avoid doing this ever again
(Closed)
Created 14 years, 10 months ago by rsc
Modified 14 years, 10 months ago
Reviewers:
Base URL:
Comments: 0