Issue 2208049: code review 2208049: syscall: fix permissions on mksysnum_nacl.sh

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2208049: code review 2208049: syscall: fix permissions on mksysnum_nacl.sh (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by rsc

Modified:
15 years, 1 month ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

syscall: fix permissions on mksysnum_nacl.sh

Patch Set 1 #

Patch Set 2 : code review 2208049: syscall: fix permissions on mksysnum_nacl.sh #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	M	src/pkg/syscall/mksysnum_nacl.sh	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-09-24 18:03:52 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=eecafc99a907 *** syscall: fix permissions on mksysnum_nacl.sh TBR=adg CC=golang-dev http://codereview.appspot.com/2208049

15 years, 1 month ago (2010-09-24 18:03:56 UTC) #2

adg

15 years, 1 month ago (2010-09-27 00:48:48 UTC) #3

LGTM

On 25 September 2010 04:03,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=eecafc99a907 ***
>
> syscall: fix permissions on mksysnum_nacl.sh
>
> TBR=adg
> CC=golang-dev
> http://codereview.appspot.com/2208049
>
>
> http://codereview.appspot.com/2208049/
>

Expand All Messages | Collapse All Messages