OpenSocial gadget editor

This is a simple opensocial gadget editor that allows developers to quickly test their gadgets against Shindig.

Here's an example editor running on my server: http://chiarg.com/opensocial/editor

Things that are left to do include:
1) Merge samplecontainer with the editor. 

Note: This change depends on CodeMirror (http://codemirror.net/) which is approved by Apache: http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200901.mbox/%3C49817894.5070805@apache.org%3E

[chirag, 2010-09-28 05:04:47]

Resending to dev@shindig.apache.org..

On Mon, Sep 27, 2010 at 9:55 PM,  <chiragshah1@gmail.com> wrote:
> Reviewers: dev-remailer_shindig.apache.org, Paul Lindner,
>
> Description:
> This is a simple opensocial gadget editor that allows developers to
> quickly test their gadgets against Shindig.
>
> Here's an example editor running on my server:
> http://chiarg.com/opensocial/editor
>
> Things that are left to do include:
> 1) POST the gadget xml into the iframe rather than passing it as a query
> parameter.
> 2) Merge the samplecontainer with the editor.
>
> Note: This change depends on CodeMirror (http://codemirror.net/) which
> is approved by Apache:
>
http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200901.mbox/%3C498...
>
>
> Please review this at http://codereview.appspot.com/2203047/
>
> Affected files:
>  content/editor/CodeMirror-0.8/LICENSE
>  content/editor/CodeMirror-0.8/css/docs.css
>  content/editor/CodeMirror-0.8/css/xmlcolors.css
>  content/editor/CodeMirror-0.8/js/codemirror.js
>  content/editor/CodeMirror-0.8/js/editor.js
>  content/editor/CodeMirror-0.8/js/highlight.js
>  content/editor/CodeMirror-0.8/js/mirrorframe.js
>  content/editor/CodeMirror-0.8/js/parsexml.js
>  content/editor/CodeMirror-0.8/js/select.js
>  content/editor/CodeMirror-0.8/js/stringstream.js
>  content/editor/CodeMirror-0.8/js/tokenize.js
>  content/editor/CodeMirror-0.8/js/tokenizejavascript.js
>  content/editor/CodeMirror-0.8/js/undo.js
>  content/editor/CodeMirror-0.8/js/util.js
>  content/editor/index.html
>
>
>

[chirag, 2010-09-28 06:19:59]

Send the rawxml parameter in post body

[Jasvir, 2010-09-29 05:49:57]

LGTM

This is a really nice-to-have.

http://codereview.appspot.com/2203047/diff/3001/content/editor/index.html
File content/editor/index.html (right):

http://codereview.appspot.com/2203047/diff/3001/content/editor/index.html#new...
content/editor/index.html:92: var url = 'http://www.gmodules.com/ig/ifr?url=';
Does gmodules require a blank url parameter for posts?

http://codereview.appspot.com/2203047/diff/3001/content/editor/index.html#new...
content/editor/index.html:95: form.submit();
Thanks for switching this to a post.

[chirag, 2010-09-29 06:10:46]

http://codereview.appspot.com/2203047/diff/3001/content/editor/index.html
File content/editor/index.html (right):

http://codereview.appspot.com/2203047/diff/3001/content/editor/index.html#new...
content/editor/index.html:92: var url = 'http://www.gmodules.com/ig/ifr?url=';
On 2010/09/29 05:49:57, jasvir wrote:
> Does gmodules require a blank url parameter for posts?

gmodules requires the url parameter but doesn't validate it. The latest version
of shindig requires the url to be well-formed.

[Paul Lindner, 2010-09-29 08:02:46]

nice!

Please add info to the top-level NOTICE file that we're including this code.

Also add entries to the top-level pom.xml to insure that codemirror will be
exempted from RAT checks.  Verify with mvn -Preporting rat:rat and look in
target/rat.txt

thx!

[Paul Lindner, 2010-09-29 08:04:21]

also consider adding a star here to get CodeMirror on google cdn:

http://code.google.com/p/google-ajax-apis/issues/detail?id=480

[chirag, 2010-09-30 03:57:52]

Update the NOTICE file and Rat check

[chirag, 2010-09-30 04:03:40]

Done and done. Thanks!

From rat.txt
 !????? content/editor/CodeMirror-0.8/css/docs.css
 !????? content/editor/CodeMirror-0.8/css/xmlcolors.css
 !????? content/editor/CodeMirror-0.8/js/codemirror.js
 !????? content/editor/CodeMirror-0.8/js/editor.js
 !????? content/editor/CodeMirror-0.8/js/highlight.js
 !????? content/editor/CodeMirror-0.8/js/mirrorframe.js
 !????? content/editor/CodeMirror-0.8/js/parsexml.js
 !????? content/editor/CodeMirror-0.8/js/select.js
 !????? content/editor/CodeMirror-0.8/js/stringstream.js
 !????? content/editor/CodeMirror-0.8/js/tokenize.js
 !????? content/editor/CodeMirror-0.8/js/tokenizejavascript.js
 !????? content/editor/CodeMirror-0.8/js/undo.js
 !????? content/editor/CodeMirror-0.8/js/util.js
  N     content/editor/CodeMirror-0.8/LICENSE
  AL    content/editor/index.html

On 2010/09/29 08:02:46, Paul Lindner wrote:
> nice!
> 
> Please add info to the top-level NOTICE file that we're including this code.
> 
> Also add entries to the top-level pom.xml to insure that codemirror will be
> exempted from RAT checks.  Verify with mvn -Preporting rat:rat and look in
> target/rat.txt
> 
> thx!

[Paul Lindner, 2010-09-30 04:14:01]

ship it!


On Wed, Sep 29, 2010 at 9:03 PM, <chiragshah1@gmail.com> wrote:

> Done and done. Thanks!
>
> From rat.txt
>  !????? content/editor/CodeMirror-0.8/css/docs.css
>  !????? content/editor/CodeMirror-0.8/css/xmlcolors.css
>  !????? content/editor/CodeMirror-0.8/js/codemirror.js
>  !????? content/editor/CodeMirror-0.8/js/editor.js
>  !????? content/editor/CodeMirror-0.8/js/highlight.js
>  !????? content/editor/CodeMirror-0.8/js/mirrorframe.js
>  !????? content/editor/CodeMirror-0.8/js/parsexml.js
>  !????? content/editor/CodeMirror-0.8/js/select.js
>  !????? content/editor/CodeMirror-0.8/js/stringstream.js
>  !????? content/editor/CodeMirror-0.8/js/tokenize.js
>  !????? content/editor/CodeMirror-0.8/js/tokenizejavascript.js
>  !????? content/editor/CodeMirror-0.8/js/undo.js
>  !????? content/editor/CodeMirror-0.8/js/util.js
>  N     content/editor/CodeMirror-0.8/LICENSE
>  AL    content/editor/index.html
>
> On 2010/09/29 08:02:46, Paul Lindner wrote:
>
>> nice!
>>
>
>  Please add info to the top-level NOTICE file that we're including this
>>
> code.
>
>  Also add entries to the top-level pom.xml to insure that codemirror
>>
> will be
>
>> exempted from RAT checks.  Verify with mvn -Preporting rat:rat and
>>
> look in
>
>> target/rat.txt
>>
>
>  thx!
>>
>
>
>
> http://codereview.appspot.com/2203047/
>



-- 
Paul Lindner -- lindner@inuus.com -- linkedin.com/in/plindner