Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 2200044: Fix Cmd-m key misbehaviour on MacOS (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by techtonik
Modified:
15 years, 9 months ago
Reviewers:
Andi Albrecht
CC:
codereview-discuss_googlegroups.com
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This fixes meta key handling on MacOS where keydown event for it is intercepted by browser (unlike Windows). Closes rietveld issue #228 arised as a followup of patchset #2055042

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M static/script.js View 2 chunks +2 lines, -0 lines 2 comments Download

Messages

Total messages: 5
techtonik
15 years, 9 months ago (2010-09-18 14:08:56 UTC) #1
Andi Albrecht
http://codereview.appspot.com/2200044/diff/1/static/script.js File static/script.js (right): http://codereview.appspot.com/2200044/diff/1/static/script.js#newcode2001 static/script.js:2001: // case ??: Meta ? What's the purpose of ...
15 years, 9 months ago (2010-09-18 16:46:24 UTC) #2
techtonik
http://codereview.appspot.com/2200044/diff/1/static/script.js File static/script.js (right): http://codereview.appspot.com/2200044/diff/1/static/script.js#newcode2001 static/script.js:2001: // case ??: Meta ? On 2010/09/18 16:46:25, Andi ...
15 years, 9 months ago (2010-09-18 17:20:25 UTC) #3
Andi Albrecht
Ok, thanks for the feedback, Anatoly! I'm fine with this to go in as it ...
15 years, 9 months ago (2010-09-18 17:44:19 UTC) #4
Andi Albrecht
15 years, 9 months ago (2010-09-19 07:36:54 UTC) #5
Committed r574 and live.

Andi Albrecht <albrecht.andi@googlemail.com> writes:

> Ok, thanks for the feedback, Anatoly!
>
> I'm fine with this to go in as it seems to have no side-effects.
>
> Andi
>
> 2010/9/18, techtonik@gmail.com <techtonik@gmail.com>:
>>
>> http://codereview.appspot.com/2200044/diff/1/static/script.js
>> File static/script.js (right):
>>
>> http://codereview.appspot.com/2200044/diff/1/static/script.js#newcode2001
>> static/script.js:2001: // case ??: Meta ?
>> On 2010/09/18 16:46:25, Andi Albrecht wrote:
>>> What's the purpose of this line? Is it a placeholder?
>>
>> Yes. But frankly it can be safely ignored, because I really can't see
>> how would "Meta" key alone could be useful for Rietveld. Just for
>> completeness I wanted to place a key code here, but it seems impossible.
>> At least on Windows I couldn't intercept the state when event.metaKey =
>> True
>>
>> http://codereview.appspot.com/2200044/
>>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b