code review 2198042: netchan: make -1 unlimited, as advertised.

netchan: make -1 unlimited, as advertised.

[r, 2010-09-15 06:38:07]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[adg, 2010-09-15 06:39:43]

LGTM

On 15 September 2010 16:38,  <r@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> netchan: make -1 unlimited, as advertised.
>
> Please review this at http://codereview.appspot.com/2198042/
>
> Affected files:
>  M src/pkg/netchan/common.go
>  M src/pkg/netchan/import.go
>
>
> Index: src/pkg/netchan/common.go
> ===================================================================
> --- a/src/pkg/netchan/common.go
> +++ b/src/pkg/netchan/common.go
> @@ -39,7 +39,7 @@
>
>  // Sent with a header once per channel from importer to exporter to report
>  // that it wants to bind to a channel with the specified direction for
> count
> -// messages.  If count is zero, it means unlimited.
> +// messages.  If count is -1, it means unlimited.
>  type request struct {
>        count int64
>        dir   Dir
> Index: src/pkg/netchan/import.go
> ===================================================================
> --- a/src/pkg/netchan/import.go
> +++ b/src/pkg/netchan/import.go
> @@ -114,7 +114,7 @@
>  // Import imports a channel of the given type and specified direction.
>  // It is equivalent to ImportNValues with a count of -1, meaning unbounded.
>  func (imp *Importer) Import(name string, chT interface{}, dir Dir) os.Error
> {
> -       return imp.ImportNValues(name, chT, dir, 0)
> +       return imp.ImportNValues(name, chT, dir, -1)
>  }
>
>  // ImportNValues imports a channel of the given type and specified
> direction
>
>
>

[r, 2010-09-15 06:41:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=ec584ae2ad58 ***

netchan: make -1 unlimited, as advertised.

R=adg
CC=golang-dev
http://codereview.appspot.com/2198042