code review 2193048: gofmt: support for ... after actual arguments

gofmt: support for ... after actual arguments

Pending acceptance of the proposed language change.

[gri, 2010-09-21 22:59:44]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-22 01:52:34]

LGTM

I had been thinking about a space before ... 
when used to expand the list, like f(args ...)
but only because I was worried about f(x + y ...) vs f(x + y...).
Now that I see it, I realize that the only way you get a
slice is with a primary expression, so leaving the space
out sounds good.

http://codereview.appspot.com/2193048/diff/2001/src/pkg/go/ast/ast.go
File src/pkg/go/ast/ast.go (right):

http://codereview.appspot.com/2193048/diff/2001/src/pkg/go/ast/ast.go#newcode217
src/pkg/go/ast/ast.go:217: Rparen   token.Position // positions of ")"
s/positions/position/

[gri, 2010-09-22 21:05:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=45f52b15d5eb ***

gofmt: support for ... after actual arguments

Pending acceptance of the proposed language change.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2193048