Issue 2190044: code review 2190044: Use vsyscall for syscall.Gettimeofday and .Time on linu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2190044: code review 2190044: Use vsyscall for syscall.Gettimeofday and .Time on linu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by iant

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, r2, golang-dev

Visibility:
Public.

Description

syscall: Use vsyscall for syscall.Gettimeofday and .Time on linux amd64. Regenerate zsyscall_linux_*.go files with recent changes to mksyscall.sh. Add socketpair to syscall_linux_amd64.go; for some reason it was in the generated file but not in the source file.

Patch Set 1 #

Patch Set 2 : code review 2190044: syscall: Use vsyscall for syscall.Gettimeofday and .Tim... #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -152 lines)			Patch
M	src/pkg/syscall/asm_linux_amd64.s	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux.go	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_386.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_amd64.go	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/syscall_linux_arm.go	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_386.go	View	10 chunks	+46 lines, -46 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_amd64.go	View	10 chunks	+39 lines, -52 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_linux_arm.go	View	11 chunks	+52 lines, -52 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 10 months ago (2010-09-21 05:57:31 UTC) #1

rsc1

LGTM I have been meaning to write a script that logs into the necessary variety ...

14 years, 10 months ago (2010-09-21 09:48:34 UTC) #2

Great. I looked into this today and was going to do it tomorrow. -rob

14 years, 10 months ago (2010-09-21 11:20:20 UTC) #3

iant

14 years, 10 months ago (2010-09-21 13:50:12 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=399daa14cae2 ***

syscall: Use vsyscall for syscall.Gettimeofday and .Time on linux amd64.

Regenerate zsyscall_linux_*.go files with recent changes to
mksyscall.sh.

Add socketpair to syscall_linux_amd64.go; for some reason it
was in the generated file but not in the source file.

R=rsc, r2
CC=golang-dev
http://codereview.appspot.com/2190044

Expand All Messages | Collapse All Messages