New module account_stock_anglo_saxon

[yangoon1, 2010-12-07 10:41:09]

http://codereview.appspot.com/2179041/diff/14001/INSTALL
File INSTALL (right):

http://codereview.appspot.com/2179041/diff/14001/INSTALL#newcode10
INSTALL:10: * trytond_stock (http://www.tryton.org/)
depends are account_invoice and account_stock_continental

http://codereview.appspot.com/2179041/diff/14001/doc/index.rst
File doc/index.rst (right):

http://codereview.appspot.com/2179041/diff/14001/doc/index.rst#newcode12
doc/index.rst:12: As usual, if the account is not defined on Product, it is the
category one that
Not correct. It is impossible to *not define* accounts on product.

[ced, 2010-12-07 10:43:58]

http://codereview.appspot.com/2179041/diff/14001/doc/index.rst
File doc/index.rst (right):

http://codereview.appspot.com/2179041/diff/14001/doc/index.rst#newcode12
doc/index.rst:12: As usual, if the account is not defined on Product, it is the
category one that
On 2010/12/07 10:41:10, yangoon wrote:
> Not correct. It is impossible to *not define* accounts on product.

It is if you check the category checkbox.

[yangoon1, 2010-12-07 11:07:04]

On 2010/12/07 10:43:58, ced wrote:
> http://codereview.appspot.com/2179041/diff/14001/doc/index.rst
> File doc/index.rst (right):
> 
> http://codereview.appspot.com/2179041/diff/14001/doc/index.rst#newcode12
> doc/index.rst:12: As usual, if the account is not defined on Product, it is
the
> category one that
> On 2010/12/07 10:41:10, yangoon wrote:
> > Not correct. It is impossible to *not define* accounts on product.
> 
> It is if you check the category checkbox.

Not for me. See last comment on http://codereview.appspot.com/2142048/

[Jan Verlaan, 2010-12-13 10:34:15]

I'am not that technical but looking at the code is do not see an exception for
stock corrections. When user inputs a stock correction as a result of e.g.
yearly stock counting, the anglo_saxon functionality should not be used.
This is a pure internal stock move to correct the stock to the actual quantity
and the corresponding financial transaction is not related to a customer.
Therefor it should not be recorded to the so called "in between" accounts where
the financial value is stored in between goods shipped/received and invoice
created/received.

Please check the inventory correction session if it is still recording the
financial transactions correct. Maybe I have overlooked the code and is this not
the case in Tryton. I have no running system to test currently.
(I know in an other ERP this is still going wrong)

[ced, 2010-12-13 19:39:55]

On 2010/12/13 10:34:15, Jan Verlaan wrote:
> I'am not that technical but looking at the code is do not see an exception for
> stock corrections. When user inputs a stock correction as a result of e.g.
> yearly stock counting, the anglo_saxon functionality should not be used.

The module generate only account moves when there is an invoice.

> This is a pure internal stock move to correct the stock to the actual quantity
> and the corresponding financial transaction is not related to a customer.
> Therefor it should not be recorded to the so called "in between" accounts
where
> the financial value is stored in between goods shipped/received and invoice
> created/received.

You mean that stock move to/from lost_found location should not generate
accounting at all?
If so, the stock account will not reflect the value of the current stock.

[Jan Verlaan, 2010-12-14 09:23:06]

On 2010/12/13 19:39:55, ced wrote:
> You mean that stock move to/from lost_found location should not generate
> accounting at all?
> If so, the stock account will not reflect the value of the current stock.
No, if a stock move to/from lost_found location generates a financial
transaction to a profit/loss account everything is working fine. What I have
seen in other ERP is that because of anglo_saxon module/functionality the
financial posting is generated to the interim/in between account instead of
profit/loss account what is wrong in case of stock corrections.

The interim/in between account is used 
(in purchase) for awaiting the invoice after receiving goods. When the invoice
arrives then a posting is done from interim/in between account to the supplier
account.
(in sales) for awaiting the generation of the invoice after sending goods. When
the invoice is created then a posting is done from interim/in between account to
the customer account.

Just want to mention that. If this is the case for Tryton should be checked. I
can not test as I do not have a Tryton server running. But one can easily test
by making a single stock correction and see if the financial booking is posted
correctly.

Hope I'm clear, don't hesitate to ask if still unclear, perhaps I should install
tryton then. ;-)

[ced, 2010-12-14 09:29:43]

On 2010/12/14 09:23:06, Jan Verlaan wrote:
> On 2010/12/13 19:39:55, ced wrote:
> > You mean that stock move to/from lost_found location should not generate
> > accounting at all?
> > If so, the stock account will not reflect the value of the current stock.
> No, if a stock move to/from lost_found location generates a financial
> transaction to a profit/loss account everything is working fine. What I have
> seen in other ERP is that because of anglo_saxon module/functionality the
> financial posting is generated to the interim/in between account instead of
> profit/loss account what is wrong in case of stock corrections.
> 
> The interim/in between account is used 
> (in purchase) for awaiting the invoice after receiving goods. When the invoice
> arrives then a posting is done from interim/in between account to the supplier
> account.
> (in sales) for awaiting the generation of the invoice after sending goods.
When
> the invoice is created then a posting is done from interim/in between account
to
> the customer account.
> 
> Just want to mention that. If this is the case for Tryton should be checked. I
> can not test as I do not have a Tryton server running. But one can easily test
> by making a single stock correction and see if the financial booking is posted
> correctly.
> 
> Hope I'm clear, don't hesitate to ask if still unclear, perhaps I should
install
> tryton then. ;-)

Ok, I understood. We must change the module account_stock_continental as it is
this
module that is in charge of account moves based on stock move.
So we should add a profit/lost account property on product like for
incoming/outgoing
accounts.

By the way, do you know if it is the interim/in that should be used in case of
return
incoming shipment?

[Jan Verlaan, 2010-12-14 09:56:14]

Great we understand this issue. :-)

On 2010/12/14 09:29:43, ced wrote:
 > By the way, do you know if it is the interim/in that should be used in case
of
> return incoming shipment?

The General Ledger should reflect the financial value for your company that
received the products but still has to generate the (credit) invoice.
You may use the interim/in account with a positive value or use the interim/out
with a negative value. In the Netherlands we have no law that force us to use
one or the other.
I would suggest the latter, for clarity. 
Then interim/in is pure supplier related and interim/out is pure customer
related.
That way the program doesn't have to change much as returns can use the same
logic only with a opposite amount.