Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 2171044: code review 2171044: (windows) disable tests that cause the build to fail (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Joe Poirier
Modified:
14 years, 10 months ago
Reviewers:
brainman
CC:
rsc, golang-dev
Visibility:
Public.

Description

(windows) disable tests that cause the build to fail

Patch Set 1 #

Patch Set 2 : code review 2171044: (windows) disable tests that cause the build to fail #

Patch Set 3 : code review 2171044: (windows) disable tests that cause the build to fail #

Patch Set 4 : code review 2171044: (windows) disable tests that cause the build to fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/run.bash View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 12
Joe Poirier
Hello rsc (cc: brainman, golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-09-12 23:39:43 UTC) #1
brainman
Will not work for me, my uname returns MINGW32_NT-5.0. Alex
14 years, 10 months ago (2010-09-13 00:18:10 UTC) #2
rsc
It sounds like we should move the host uname variable into the standard go environment ...
14 years, 10 months ago (2010-09-13 02:15:36 UTC) #3
Joe Poirier
Hello rsc, brainman (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 10 months ago (2010-09-13 02:42:41 UTC) #4
rsc
LGTM leaving for brainman
14 years, 10 months ago (2010-09-13 02:56:12 UTC) #5
Joe Poirier
On 2010/09/13 02:56:12, rsc wrote: > LGTM > > leaving for brainman > There are ...
14 years, 10 months ago (2010-09-13 03:09:42 UTC) #6
Joe Poirier
Hello rsc, brainman (cc: golang-dev@googlegroups.com), Please take another look.
14 years, 10 months ago (2010-09-13 03:11:20 UTC) #7
Joe Poirier
If this CL is going to be accepted it'd be greatly appreciated if happens before ...
14 years, 10 months ago (2010-09-13 03:24:39 UTC) #8
brainman
*** Submitted as http://code.google.com/p/go/source/detail?r=45da28e6e4f9 *** (windows) disable tests that cause the build to fail R=rsc, ...
14 years, 10 months ago (2010-09-13 03:36:55 UTC) #9
brainman
> It sounds like we should move the host uname variable > into the standard ...
14 years, 10 months ago (2010-09-13 03:38:43 UTC) #10
Joe Poirier
On Sun, Sep 12, 2010 at 10:38 PM, <alex.brainman@gmail.com> wrote: >> It sounds like we ...
14 years, 10 months ago (2010-09-13 03:47:43 UTC) #11
brainman
14 years, 10 months ago (2010-09-13 04:28:30 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b