code review 217048: Unified body transfer (read & write) logic in http.Requ...

Unified body transfer (read & write) logic in http.Request/Response.

Compliance issue addressed here: POST requests carrying form data are required
to use "identity" transfer encoding by common nginx and apache server configurations,
e.g. wordpress.com (and many others). So, Request needed to be able to send
non-chunked encodings.

Thus, Request is extended to support identity and chunked encodings, like
Response.  Since the Read() and Write() logic are shared by both (and are
quite long), it is exported in a separate file transfer.go.

[petar-m, 2010-02-19 14:51:49]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-19 16:19:51]

looks good

http://codereview.appspot.com/217048/diff/22/25
File src/pkg/http/request.go (right):

http://codereview.appspot.com/217048/diff/22/25#newcode94
src/pkg/http/request.go:94: // ContentLength records the length of the
associated content.  The
break lines at sentences.
(move The onto next line,
Values onto next line)

http://codereview.appspot.com/217048/diff/22/25#newcode99
src/pkg/http/request.go:99: // Contains transfer encodings from outer-most to
inner-most. Value is
// TransferEncoding lists the transfer encodings from outermost to innermost.
// An empty list denotes the "identity" encoding.

http://codereview.appspot.com/217048/diff/22/26
File src/pkg/http/requestwrite_test.go (right):

http://codereview.appspot.com/217048/diff/22/26#newcode87
src/pkg/http/requestwrite_test.go:87: // FIXME(petar): The write order of keys
in Request.Header depends on the
can probably delete this comment?

[petar-m, 2010-02-19 16:26:41]

Done.

http://codereview.appspot.com/217048/diff/22/25
File src/pkg/http/request.go (right):

http://codereview.appspot.com/217048/diff/22/25#newcode94
src/pkg/http/request.go:94: // ContentLength records the length of the
associated content.  The
On 2010/02/19 16:19:51, rsc wrote:
> break lines at sentences.
> (move The onto next line,
> Values onto next line)
> 

Done.

http://codereview.appspot.com/217048/diff/22/25#newcode99
src/pkg/http/request.go:99: // Contains transfer encodings from outer-most to
inner-most. Value is
On 2010/02/19 16:19:51, rsc wrote:
> // TransferEncoding lists the transfer encodings from outermost to innermost.
> // An empty list denotes the "identity" encoding.
> 

Done.

http://codereview.appspot.com/217048/diff/22/26
File src/pkg/http/requestwrite_test.go (right):

http://codereview.appspot.com/217048/diff/22/26#newcode87
src/pkg/http/requestwrite_test.go:87: // FIXME(petar): The write order of keys
in Request.Header depends on the
On 2010/02/19 16:19:51, rsc wrote:
> can probably delete this comment?
> 

Done.

[rsc, 2010-02-19 16:38:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=78cf751607b4 ***

http: unified body transfer (read & write) logic in http.Request/Response.

Compliance issue addressed here: POST requests carrying form data are required
to use "identity" transfer encoding by common nginx and apache server
configurations,
e.g. wordpress.com (and many others). So, Request needed to be able to send
non-chunked encodings.

Thus, Request is extended to support identity and chunked encodings, like
Response.  Since the Read() and Write() logic are shared by both (and are
quite long), it is exported in a separate file transfer.go.

R=rsc
CC=golang-dev
http://codereview.appspot.com/217048

Committer: Russ Cox <rsc@golang.org>