Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 217047: code review 217047: fix quoted strings in Marshal

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by skorobo
Modified:
10 years, 4 months ago
Reviewers:
rsc
CC:
rsc, golang-dev
Visibility:
Public.

Description

fix quoted strings in Marshal

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review 217047: fix quoted strings in Marshal #

Patch Set 3 : code review 217047: fix quoted strings in Marshal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -29 lines) Patch
M src/pkg/json/struct.go View 1 2 2 chunks +62 lines, -29 lines 0 comments Download
M src/pkg/json/struct_test.go View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rsc
looks good. please change the comment and also run "hg change 217047" and edit the ...
15 years, 5 months ago (2010-02-19 16:37:35 UTC) #1
skorobo
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years, 5 months ago (2010-02-19 16:52:53 UTC) #2
skorobo
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
15 years, 5 months ago (2010-02-19 20:43:57 UTC) #3
rsc
LGTM thanks
15 years, 5 months ago (2010-02-19 20:47:05 UTC) #4
rsc
Please complete a CLA as described at http://golang.org/doc/contribute.html#copyright
15 years, 5 months ago (2010-02-19 20:48:52 UTC) #5
skorobo
Completed. > Please complete a CLA as described at > http://golang.org/doc/contribute.html#copyright
15 years, 5 months ago (2010-02-19 21:32:32 UTC) #6
rsc
15 years, 5 months ago (2010-02-22 22:32:42 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=011400aed900 ***

json: fix quoted strings in Marshal

R=rsc
CC=golang-dev
http://codereview.appspot.com/217047

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b