code review 2169041: freetype: cache glyphs during DrawText.

freetype: cache glyphs during DrawText.
A freetype.Context now has dst and src image setters and the notion of
a current point, instead of having to pass a painter and pt to DrawText.

[nigeltao, 2010-09-07 14:37:59]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-08 14:24:15]

LGTM

leaving for rob

[r, 2010-09-09 05:01:34]

LGTM

http://codereview.appspot.com/2169041/diff/5001/freetype/freetype.go
File freetype/freetype.go (right):

http://codereview.appspot.com/2169041/diff/5001/freetype/freetype.go#newcode22
freetype/freetype.go:22: // nXFractions possible values in the X direction and
similarly for Y.
avoid the adverb
..possible values in both the X and Y directions.
but i'd use x and y sted X and Y.

http://codereview.appspot.com/2169041/diff/5001/freetype/freetype.go#newcode57
freetype/freetype.go:57: // pt is the location where drawing starts from.
s/ from//

http://codereview.appspot.com/2169041/diff/5001/freetype/freetype.go#newcode288
freetype/freetype.go:288: // SetDst sets the destination image to draw text.
s/image/& in which/

http://codereview.appspot.com/2169041/diff/5001/freetype/freetype.go#newcode293
freetype/freetype.go:293: // SetSrc sets the source image to draw text. This is
typically an
s//& from which/

or here and above you could say something the "the source image for draw
operations" and it would be clear. the problem with the current comment is
confusing grammar rather than intent

[nigeltao, 2010-09-09 09:22:36]

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=b76de01666fe ***

freetype: cache glyphs during DrawText.
A freetype.Context now has dst and src image setters and the notion of
a current point, instead of having to pass a painter and pt to DrawText.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/2169041