Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 2167045: code review 2167045: libmach: fix new thread race with Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by rsc
Modified:
14 years, 10 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

libmach: fix new thread race with Linux If you look at the sequence of values returned by waitpid, it simply tells us about the child of clone before it tells us that the parent called clone. There's nothing we can do but assume unexpected tids are newly cloned children. Tested with 6prof on godoc. Fixes issue 251.

Patch Set 1 #

Patch Set 2 : code review 2167045: libmach: fix new thread race with Linux #

Patch Set 3 : code review 2167045: libmach: fix new thread race with Linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/libmach/linux.c View 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-09-11 04:24:26 UTC) #1
r
LGTM
14 years, 10 months ago (2010-09-11 06:04:22 UTC) #2
rsc
14 years, 10 months ago (2010-09-12 03:42:06 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9eab1d4efd3b ***

libmach: fix new thread race with Linux

If you look at the sequence of values returned
by waitpid, it simply tells us about the child of
clone before it tells us that the parent called clone.
There's nothing we can do but assume unexpected
tids are newly cloned children.

Tested with 6prof on godoc.

Fixes issue 251.

R=r
CC=golang-dev
http://codereview.appspot.com/2167045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b