Issue 216059: code review 216059: go/ast: use a slice instead of a linked list for the li...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 216059: code review 216059: go/ast: use a slice instead of a linked list for the li... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by gri

Modified:
15 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/ast: use a slice instead of a linked list for the list of comments (this will simplify some further changes) removed several TODOs

Patch Set 1 #

Patch Set 2 : code review 216059: go/ast: use a slice instead of a linked list for the li... #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -42 lines)			Patch
M	src/pkg/go/ast/ast.go	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	src/pkg/go/ast/filter.go	View	4 chunks	+2 lines, -9 lines	0 comments	Download
M	src/pkg/go/ast/walk.go	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/pkg/go/doc/doc.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/go/printer/printer.go	View	4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 5 months ago (2010-02-20 00:31:22 UTC) #1

gri

15 years, 5 months ago (2010-02-20 01:03:11 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=0692c79ada0a ***

go/ast: use a slice instead of a linked list for the list of comments
        (this will simplify some further changes)
removed several TODOs

R=rsc
CC=golang-dev
http://codereview.appspot.com/216059

Expand All Messages | Collapse All Messages