Issue 2149044: code review 2149044: freetype: Split AlphaPainter into two separate types de...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2149044: code review 2149044: freetype: Split AlphaPainter into two separate types de... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by nigeltao

Modified:
13 years, 9 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

freetype: Split AlphaPainter into two separate types depending on the Porter-Duff composition operator used. This saves a malloc when passing an AlphaSrcPainter as a value of Painter interface type.

Patch Set 1 #

Patch Set 2 : code review 2149044: freetype: Split AlphaPainter into two separate types de... #

Patch Set 3 : code review 2149044: freetype: Split AlphaPainter into two separate types de... #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -22 lines)			Patch
	M	freetype/freetype.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	freetype/raster/paint.go	View		2 chunks	+38 lines, -21 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-09-09 09:55:43 UTC) #1

nigeltao

13 years, 9 months ago (2010-09-10 02:06:53 UTC) #3

*** Submitted as
http://code.google.com/p/freetype-go/source/detail?r=cc1b7e3cd4b3 ***

freetype: Split AlphaPainter into two separate types depending on the
Porter-Duff composition operator used. This saves a malloc when passing
an AlphaSrcPainter as a value of Painter interface type.

R=r
CC=golang-dev
http://codereview.appspot.com/2149044

Expand All Messages | Collapse All Messages