code review 2145043: test: removed syntax tests for slices

test: removed syntax tests for slices

[bytbox, 2010-09-09 04:11:54]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-09-09 04:21:51]

why is this test not failing on the dashboard?

On Thu, Sep 9, 2010 at 00:11,  <bytbox@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> test: update syntax tests for omission of low slice bound
>
> Please review this at http://codereview.appspot.com/2145043/
>
> Affected files:
>  M test/syntax/slice.go
>
>
> Index: test/syntax/slice.go
> ===================================================================
> --- a/test/syntax/slice.go
> +++ b/test/syntax/slice.go
> @@ -6,4 +6,9 @@
>
>  package main
>
> -var x = y[:z]  // ERROR "missing lower bound in slice expression|undefined"
> +var a = []int{1, 2, 3, 4, 5}
> +var b = a[:]
> +var c = a[:2]
> +var d = a[2:]
> +var x = y[:z]  // ERROR "undefined"
> +
>
>
>

[bytbox, 2010-09-09 04:23:51]

On 09/09/2010 12:21 AM, Russ Cox wrote:
> why is this test not failing on the dashboard?

Currently it consists solely of:
var x = y[:z]  // ERROR "missing lower bound in slice expression|undefined"

And since y and z are undefined, the error message matches. If you take
away the 'undefined', it fails.

[rsc, 2010-09-09 04:52:40]

On Thu, Sep 9, 2010 at 00:25, Scott Lawrence <bytbox@gmail.com> wrote:
> On 09/09/2010 12:21 AM, Russ Cox wrote:
>> why is this test not failing on the dashboard?
>
> Currently it consists solely of:
> var x = y[:z]  // ERROR "missing lower bound in slice expression|undefined"
>
> And since y and z are undefined, the error message matches. If you take
> away the 'undefined', it fails.

ha ha.  the test/syntax directory is for syntax errors.
There are no syntax errors relating to omitted bounds
anymore, so this file should just be deleted.

Russ

[bytbox, 2010-09-09 04:54:52]

Hello golang-dev@googlegroups.com, rsc1, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-09-09 04:55:47]

LGTM

[rsc, 2010-09-09 05:42:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=fb77e7e00635 ***

test: remove slice syntax test

R=rsc
CC=golang-dev
http://codereview.appspot.com/2145043

Committer: Russ Cox <rsc@golang.org>