Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 2140046: code review 2140046: Add windows NOTEST list to pkg make file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Joe Poirier
Modified:
15 years, 1 month ago
Reviewers:
brainman
CC:
rsc, golang-dev
Visibility:
Public.

Description

Add windows NOTEST list to pkg make file. 5a make file. the change removes a space character that was included when appending an extension to TARG.

Patch Set 1 #

Patch Set 2 : code review 2140046: Add windows NOTEST list to pkg make file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/cmd/5a/Makefile View 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/Makefile View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Joe Poirier
Hello brainman (cc: golang-dev@googlegroups.com, rsc), I'd like you to review this change.
15 years, 1 month ago (2010-09-10 17:52:24 UTC) #1
rsc
LGTM
15 years, 1 month ago (2010-09-10 17:54:01 UTC) #2
rsc
*** Submitted as 5ccdd03fd7a4 *** windows: disable unimplemented tests Add windows NOTEST list to pkg ...
15 years, 1 month ago (2010-09-10 18:05:59 UTC) #3
brainman
15 years, 1 month ago (2010-09-11 00:58:33 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b