Issue 2140046: code review 2140046: Add windows NOTEST list to pkg make file.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2140046: code review 2140046: Add windows NOTEST list to pkg make file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by Joe Poirier

Modified:
15 years, 1 month ago

Reviewers:
brainman

CC:
rsc, golang-dev

Visibility:
Public.

Add windows NOTEST list to pkg make file. 5a make file. the change removes a space character that was included when appending an extension to TARG.

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	src/cmd/5a/Makefile	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/pkg/Makefile	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 4

Joe Poirier

Hello brainman (cc: golang-dev@googlegroups.com, rsc), I'd like you to review this change.

15 years, 1 month ago (2010-09-10 17:52:24 UTC) #1

rsc

*** Submitted as 5ccdd03fd7a4 *** windows: disable unimplemented tests Add windows NOTEST list to pkg ...

15 years, 1 month ago (2010-09-10 18:05:59 UTC) #3

LGTM